From: Eric Sandeen <sandeen@redhat.com>
To: Theodore Tso <tytso@mit.edu>
Cc: ext4 development <linux-ext4@vger.kernel.org>,
"Jose R. Santos" <jrs@us.ibm.com>
Subject: Re: [PATCH, RFC] ext4: flex_bg ialloc, don't pick "best_flex" with 0 inodes
Date: Sat, 16 Aug 2008 12:35:18 -0500 [thread overview]
Message-ID: <48A70FD6.80709@redhat.com> (raw)
In-Reply-To: <20080816152541.GB8422@mit.edu>
Theodore Tso wrote:
> On Fri, Aug 15, 2008 at 05:01:10PM -0500, Eric Sandeen wrote:
>> It seems like adjusting the following test is a better plan;
>> for starters I do not see that best_flex can ever be < 0, so
>
> Given that ext4_group_t is an unsigned long, that's certainly true.
> :-)
Heh, that too!
>> that test is replaced, and if the current "best" flex group
>> has no inodes free, and the current one does have room,
>> it is promoted to the next "best."
>
> Looks good to me. I've added it to the patch queue.
>
>> Signed-of-by: Eric Sandeen <sandeen@redhat.com>
>
> (forgot an 'f' :-)
Urk...
Thanks!
-Eric
> Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
>
> - Ted
prev parent reply other threads:[~2008-08-16 18:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-15 22:01 [PATCH, RFC] ext4: flex_bg ialloc, don't pick "best_flex" with 0 inodes Eric Sandeen
2008-08-16 15:25 ` Theodore Tso
2008-08-16 17:35 ` Eric Sandeen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48A70FD6.80709@redhat.com \
--to=sandeen@redhat.com \
--cc=jrs@us.ibm.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox