From: Eric Sandeen <sandeen@redhat.com>
To: Andreas Dilger <adilger@sun.com>
Cc: "Theodore Ts'o" <tytso@mit.edu>, linux-ext4@vger.kernel.org
Subject: Re: [PATCH] e2fsck shouln't consider superblock summaries as fatal
Date: Tue, 26 Aug 2008 09:58:39 -0500 [thread overview]
Message-ID: <48B41A1F.5060809@redhat.com> (raw)
In-Reply-To: <20080826104502.GH3392@webber.adilger.int>
Andreas Dilger wrote:
> Running e2fsck on a quiescent (but mounted) filesystem fails in the
> common case where the superblock inode and block count summaries are
> wrong. The kernel doesn't update these values except at unmount time.
> If there are other errors in the filesystem then they will already
> cause e2fsck to consider the filesystem invalid, so these minor errors
> should not.
If by quiescent, if you mean ->write_super_lockfs, shouldn't that path
be indistinguishable from an unmount? Why wouldn't write_super_lockfs
also update these counts, rather than working around it in fsck?
-Eric
> Don't consider only an error in the superblock summary as incorrect.
> The kernel does not update this field except at unmount time. Any
> other unfixed errors will themselves mark the filesystem invalid.
>
> Signed-off-by: Andreas Dilger <adilger@sun.com>
next prev parent reply other threads:[~2008-08-26 15:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-26 10:45 [PATCH] e2fsck shouln't consider superblock summaries as fatal Andreas Dilger
2008-08-26 14:58 ` Eric Sandeen [this message]
2008-08-26 17:04 ` Theodore Tso
2008-08-26 21:27 ` Andreas Dilger
2008-08-27 0:25 ` Theodore Tso
2008-08-27 7:32 ` Andreas Dilger
2008-08-27 13:44 ` Theodore Tso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48B41A1F.5060809@redhat.com \
--to=sandeen@redhat.com \
--cc=adilger@sun.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).