From: Eric Sandeen <sandeen@redhat.com>
To: ext4 development <linux-ext4@vger.kernel.org>
Subject: [PATCH] properly show journal checksum/async options
Date: Sun, 14 Sep 2008 14:18:59 -0700 [thread overview]
Message-ID: <48CD7FC3.4050807@redhat.com> (raw)
The journal_checksum option is not being displayed in
/proc/mounts ... add this to the show_options() output, but
only if journal_async_commit is not specified, as that enables
journal_checksum internally.
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---
(Aside: this reminds me that we only show non-default options
in show_options; has there been any discussion of whether
these should be defaults?)
Index: linux-2.6/fs/ext4/super.c
===================================================================
--- linux-2.6.orig/fs/ext4/super.c 2008-09-14 16:12:54.898077064 -0500
+++ linux-2.6/fs/ext4/super.c 2008-09-14 16:13:22.878077407 -0500
@@ -746,8 +746,12 @@ static int ext4_show_options(struct seq_
*/
seq_puts(seq, ",barrier=");
seq_puts(seq, test_opt(sb, BARRIER) ? "1" : "0");
+ /* journal_async_commit enables journal_checksum internally */
if (test_opt(sb, JOURNAL_ASYNC_COMMIT))
seq_puts(seq, ",journal_async_commit");
+ else if (test_opt(sb, JOURNAL_CHECKSUM))
+ seq_puts(seq, ",journal_checksum");
+
if (test_opt(sb, NOBH))
seq_puts(seq, ",nobh");
if (!test_opt(sb, EXTENTS))
next reply other threads:[~2008-09-14 21:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-14 21:18 Eric Sandeen [this message]
2008-09-20 22:06 ` [PATCH] properly show journal checksum/async options Theodore Tso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48CD7FC3.4050807@redhat.com \
--to=sandeen@redhat.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).