From: Eric Sandeen <sandeen@redhat.com>
To: ext4 development <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH] e2fsprogs: exit from preenhalt if IO errors were encountered
Date: Fri, 10 Oct 2008 17:39:01 -0500 [thread overview]
Message-ID: <48EFD985.6090206@redhat.com> (raw)
In-Reply-To: <48EFD3B0.4060009@redhat.com>
Eric Sandeen wrote:
> Resolves RH Bug 465679- e2fsck -p crashes with read-only DM device (e.g. logical volume)
>
> If a block device is unwritable, e2fsck -p gets into an infinite loop
> trying to preenhalt, close & flush the fs, which tries to flush the cache,
> which gets a write error and calls preenhalt which tries to close & flush
> the fs ... ad infinitum.
>
> Per Ted's suggestion just flag the ctx as "exiting" and short-circuit
> the infinite loop.
>
> Tested by running e2fsck -p on a block device set read-only by BLKROSET.
Oh, thanks to Vlado Potisk for reporting this.
-Eric
prev parent reply other threads:[~2008-10-10 22:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-10 22:14 [PATCH] e2fsprogs: exit from preenhalt if IO errors were encountered Eric Sandeen
2008-10-10 22:39 ` Eric Sandeen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48EFD985.6090206@redhat.com \
--to=sandeen@redhat.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox