From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80151C28CC1 for ; Wed, 29 May 2019 18:34:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5C51724074 for ; Wed, 29 May 2019 18:34:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727477AbfE2SeT (ORCPT ); Wed, 29 May 2019 14:34:19 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40810 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725956AbfE2SeT (ORCPT ); Wed, 29 May 2019 14:34:19 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 2BCF4C05B1CD; Wed, 29 May 2019 18:34:09 +0000 (UTC) Received: from [IPv6:::1] (ovpn04.gateway.prod.ext.phx2.redhat.com [10.5.9.4]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 58804611AD; Wed, 29 May 2019 18:34:07 +0000 (UTC) Subject: Re: How to package e2scrub To: "Darrick J. Wong" , Lukas Czerner Cc: linux-ext4@vger.kernel.org, Jan Kara , Theodore Ts'o , xfs References: <20190529120603.xuet53xgs6ahfvpl@work> <20190529182111.GA5220@magnolia> From: Eric Sandeen Message-ID: <48b9290c-ac0a-b5b2-ab27-970282ae242e@redhat.com> Date: Wed, 29 May 2019 13:34:06 -0500 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <20190529182111.GA5220@magnolia> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Wed, 29 May 2019 18:34:19 +0000 (UTC) Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On 5/29/19 1:21 PM, Darrick J. Wong wrote: > On Wed, May 29, 2019 at 02:06:03PM +0200, Lukas Czerner wrote: >> Hi guys, >> >> I am about to release 1.45.2 for Fedora rawhide, but I was thinking >> about how to package the e2scrub cron job/systemd service. > > Funny, xfs has the same conundrum. Adding Eric & xfs list to cc... > >> I really do not like the idea of installing cron job and/or the service as >> a part of regular e2fsprogs package. This can potentially really surprise >> people in a bad way. >> >> Note that I've already heard some complaints from debian users about the >> systemd service being installed on their system after the e2fsprogs >> update. > > Yeah, e2scrub is bitrotting rather faster than I had thought it > would... but it's only available in Debian unstable. > >> What I am going to do is to split the systemd service into a separate >> package and I'd like to come to some agreement about the name of the >> package so that we can have the same name across distributions (at least >> Fedora/Debian/Suse). > > Indeed. Eric picked "xfsprogs-xfs_scrub" for Rawhide, though I find > that name to be very clunky and would have preferred "xfs_scrub". Yes it is a bit clunky but *shrug* The main motivator for this was one piece uses python3 and that Made People Sad who wanted minimal systems with minimal deps but still wanted xfsprogs. Keeping services separate is a good idea as well, I think. I don't have a strong opinion on whether /just/ the service should be separate, or the scrub util + the service should be separate. I put all the xfs scrubbing bits in one package in rawhide. -Eric