public inbox for linux-ext4@vger.kernel.org
 help / color / mirror / Atom feed
From: Thorsten Leemhuis <regressions@leemhuis.info>
To: hazem ahmed mohamed <hazem.ahmed.abuelfotoh@gmail.com>,
	"linux-ext4@vger.kernel.org" <linux-ext4@vger.kernel.org>,
	"tytso@mit.edu" <tytso@mit.edu>,
	"adilger.kernel@dilger.ca" <adilger.kernel@dilger.ca>,
	"regressions@lists.linux.dev" <regressions@lists.linux.dev>,
	"stable@vger.kernel.org" <stable@vger.kernel.org>
Cc: "Mohamed Abuelfotoh, Hazem" <abuehaze@amazon.com>
Subject: Re: Ext4: Buffered random writes performance regression with dioread_nolock enabled
Date: Tue, 20 Sep 2022 10:07:07 +0200	[thread overview]
Message-ID: <48bb6266-2d5c-ffcd-6982-4fd02bfdcfc3@leemhuis.info> (raw)
In-Reply-To: <CACX6voDfcTQzQJj=5Q-SLi0in1hXpo=Ri28rX73Og3GTObPBWA@mail.gmail.com>

On 19.09.22 17:18, hazem ahmed mohamed wrote:
> 
> I am sending this e-mail to report a performance regression that’s
> caused by commit 244adf6426(ext4: make dioread_nolock the default) , I
> am listing the performance regression symptoms below & our analysis
> for the reported regression.

FWIW, that patch went into v5.6-rc1~113^2~12

And BTW: it seems 0-day back then noticed that 244adf6426 caused a
performance regression as well, but it seems that was ignored:
https://lore.kernel.org/all/20201024120829.GK31092@shao2-debian/

Anyway, now to the main reason why I write this mail:

[TLDR: I'm adding this regression report to the list of tracked
regressions; all text from me you find below is based on a few templates
paragraphs you might have encountered already already in similar form.]

Thanks for the report. To be sure below issue doesn't fall through the
cracks unnoticed, I'm adding it to regzbot, my Linux kernel regression
tracking bot:

#regzbot ^introduced 244adf6426
#regzbot ignore-activity

This isn't a regression? This issue or a fix for it are already
discussed somewhere else? It was fixed already? You want to clarify when
the regression started to happen? Or point out I got the title or
something else totally wrong? Then just reply -- ideally with also
telling regzbot about it, as explained here:
https://linux-regtracking.leemhuis.info/tracked-regression/

Reminder for developers: When fixing the issue, add 'Link:' tags
pointing to the report (the mail this one replies to), as explained for
in the Linux kernel's documentation; the webpage mention at the end of
the last para explains why this is important for tracked regressions.

Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)

P.S.: As the Linux kernel's regression tracker I deal with a lot of
reports and sometimes miss something important when writing mails like
this. If that's the case here, don't hesitate to tell me in a public
reply, it's in everyone's interest to set the public record straight.

  reply	other threads:[~2022-09-20  8:11 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-19 15:18 Ext4: Buffered random writes performance regression with dioread_nolock enabled hazem ahmed mohamed
2022-09-20  8:07 ` Thorsten Leemhuis [this message]
2022-09-20 13:59   ` hazem ahmed mohamed
2022-09-21  2:41   ` Theodore Ts'o
2022-09-21  9:55     ` Thorsten Leemhuis
2022-09-21  4:44 ` Ritesh Harjani (IBM)
2022-09-21 12:22   ` hazem ahmed mohamed
     [not found] <28460B7B-F66E-4BDC-9F6E-B7E77A3FEE83@amazon.com>
2022-09-21  2:07 ` Theodore Ts'o
2022-09-21 12:06   ` Mohamed Abuelfotoh, Hazem

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48bb6266-2d5c-ffcd-6982-4fd02bfdcfc3@leemhuis.info \
    --to=regressions@leemhuis.info \
    --cc=abuehaze@amazon.com \
    --cc=adilger.kernel@dilger.ca \
    --cc=hazem.ahmed.abuelfotoh@gmail.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=regressions@lists.linux.dev \
    --cc=stable@vger.kernel.org \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox