From: Eric Sandeen <sandeen@redhat.com>
To: Andreas Dilger <adilger@sun.com>
Cc: ext4 development <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH] e2fsck: ignore differing NEEDS_RECOVERY flag on backup sbs
Date: Sat, 22 Nov 2008 21:29:07 -0600 [thread overview]
Message-ID: <4928CE03.8010003@redhat.com> (raw)
In-Reply-To: <20081122173654.GE3186@webber.adilger.int>
Andreas Dilger wrote:
> On Nov 22, 2008 09:02 -0600, Eric Sandeen wrote:
>> This is for RH bugzilla 471925 - Complete scan of filesystems expanded online
>>
>> When we resize online, the primary superblock gets copied to all
>> the backups, and of course since we're mounted the NEEDS_RECOVERY
>> flag is set. A subsequent fsck will find the backups have the
>> NEEDS_RECOVERY flag set while the primary does not, and this
>> forces a full fsck pass.
>>
>> I think this flag can be safely ignored in the flag comparisons.
>
> Should we also mask out this flag from the backup superblock copies
> when they are made, or is there an equal chance that the superblock
> has NEEDS_RECOVERY and the backups do not?
I think it might be a good idea (to mask at growfs time) for
completeness. Is there *ever* any valid reason for a backup superblock
to have this flag set? Near as I can tell, online growfs is the only
thing that ever sets it, and this "flag match" check is the only thing
that ever tests it.
-Eric
next prev parent reply other threads:[~2008-11-23 3:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-22 15:02 [PATCH] e2fsck: ignore differing NEEDS_RECOVERY flag on backup sbs Eric Sandeen
2008-11-22 17:36 ` Andreas Dilger
2008-11-23 3:29 ` Eric Sandeen [this message]
2009-03-26 16:31 ` Eric Sandeen
2009-04-07 17:22 ` Theodore Tso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4928CE03.8010003@redhat.com \
--to=sandeen@redhat.com \
--cc=adilger@sun.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).