From: Bill Davidsen <davidsen@tmr.com>
To: Theodore Tso <tytso@mit.edu>, Bill Davidsen <davidsen@tmr.com>,
roel kluin <roel.kluin@gmail.com>,
adilger@sun.com, linux-ext4@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] ext3, ext4: do_split() fix loop, with obvious unsigned wrap
Date: Wed, 03 Dec 2008 09:25:46 -0500 [thread overview]
Message-ID: <493696EA.5060900@tmr.com> (raw)
In-Reply-To: <4935C219.3070006@tmr.com>
Bill Davidsen wrote:
> I seriously disagree on that, writing it as a for makes it totally
> clear that the index initialization is part of the loop.
> I know, looks funny, not the way we have always done it, not invented
> here...
>
Just to be clear, I didn't mean that in any bad way, just that sometimes
a new format, even if correct and unambiguous, looks strange to the eye
and is not used just because it jars. I still think putting
initialization for a loop in the start of the for is defensive
programming, perhaps I've had too many bumblers inherit my code.
--
Bill Davidsen <davidsen@tmr.com>
"Woe unto the statesman who makes war without a reason that will still
be valid when the war is over..." Otto von Bismark
next prev parent reply other threads:[~2008-12-03 14:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-01 19:28 [PATCH v2] ext3, ext4: do_split() fix loop, with obvious unsigned wrap roel kluin
2008-12-02 13:24 ` Theodore Tso
2008-12-02 17:08 ` Bill Davidsen
2008-12-02 19:47 ` Roel Kluin
2008-12-02 21:57 ` Theodore Tso
2008-12-02 23:17 ` Bill Davidsen
2008-12-03 14:25 ` Bill Davidsen [this message]
2008-12-03 6:05 ` Andrew Morton
2008-12-03 14:32 ` Bill Davidsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=493696EA.5060900@tmr.com \
--to=davidsen@tmr.com \
--cc=adilger@sun.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=roel.kluin@gmail.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).