* [PATCH -next] jbd2: fix printk format warning [not found] <20090105173517.deeff918.sfr@canb.auug.org.au> @ 2009-01-05 20:11 ` Randy Dunlap 2009-01-11 18:52 ` Simon Holm Thøgersen 0 siblings, 1 reply; 4+ messages in thread From: Randy Dunlap @ 2009-01-05 20:11 UTC (permalink / raw) To: Stephen Rothwell, akpm; +Cc: linux-next, LKML, linux-ext4 From: Randy Dunlap <randy.dunlap@oracle.com> Fix jbd2 printk format: fs/jbd2/journal.c:848: warning: format '%lu' expects type 'long unsigned int', but argument 3 has type 'uint32_t' Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com> --- fs/jbd2/journal.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- linux-next-20090105.orig/fs/jbd2/journal.c +++ linux-next-20090105/fs/jbd2/journal.c @@ -845,7 +845,8 @@ static int jbd2_seq_info_show(struct seq seq_printf(seq, " %ums logging transaction\n", jiffies_to_msecs(s->stats->u.run.rs_logging / s->stats->ts_tid)); seq_printf(seq, " %luus average transaction commit time\n", - do_div(s->journal->j_average_commit_time, 1000)); + (unsigned long)do_div(s->journal->j_average_commit_time, + 1000)); seq_printf(seq, " %lu handles per transaction\n", s->stats->u.run.rs_handle_count / s->stats->ts_tid); seq_printf(seq, " %lu blocks per transaction\n", ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH -next] jbd2: fix printk format warning 2009-01-05 20:11 ` [PATCH -next] jbd2: fix printk format warning Randy Dunlap @ 2009-01-11 18:52 ` Simon Holm Thøgersen 2009-01-11 19:07 ` Randy Dunlap 0 siblings, 1 reply; 4+ messages in thread From: Simon Holm Thøgersen @ 2009-01-11 18:52 UTC (permalink / raw) To: Randy Dunlap; +Cc: Stephen Rothwell, akpm, linux-next, LKML, linux-ext4 man, 05 01 2009 kl. 12:11 -0800, skrev Randy Dunlap: > From: Randy Dunlap <randy.dunlap@oracle.com> > > Fix jbd2 printk format: > > fs/jbd2/journal.c:848: warning: format '%lu' expects type 'long unsigned int', > but argument 3 has type 'uint32_t' > > Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com> > --- > fs/jbd2/journal.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > --- linux-next-20090105.orig/fs/jbd2/journal.c > +++ linux-next-20090105/fs/jbd2/journal.c > @@ -845,7 +845,8 @@ static int jbd2_seq_info_show(struct seq > seq_printf(seq, " %ums logging transaction\n", > jiffies_to_msecs(s->stats->u.run.rs_logging / s->stats->ts_tid)); > seq_printf(seq, " %luus average transaction commit time\n", > - do_div(s->journal->j_average_commit_time, 1000)); > + (unsigned long)do_div(s->journal->j_average_commit_time, > + 1000)); > seq_printf(seq, " %lu handles per transaction\n", > s->stats->u.run.rs_handle_count / s->stats->ts_tid); > seq_printf(seq, " %lu blocks per transaction\n", This patch is just as wrong as the original code. Please don't apply it, but see my "[PATCH] jbd2: fix wrong use of do_div" that I just sent out. Simon Holm Thøgersen ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH -next] jbd2: fix printk format warning 2009-01-11 18:52 ` Simon Holm Thøgersen @ 2009-01-11 19:07 ` Randy Dunlap 2009-01-11 19:20 ` Simon Holm Thøgersen 0 siblings, 1 reply; 4+ messages in thread From: Randy Dunlap @ 2009-01-11 19:07 UTC (permalink / raw) To: Simon Holm Thøgersen Cc: Randy Dunlap, Stephen Rothwell, akpm, linux-next, LKML, linux-ext4 Simon Holm Thøgersen wrote: > man, 05 01 2009 kl. 12:11 -0800, skrev Randy Dunlap: >> From: Randy Dunlap <randy.dunlap@oracle.com> >> >> Fix jbd2 printk format: >> >> fs/jbd2/journal.c:848: warning: format '%lu' expects type 'long unsigned int', >> but argument 3 has type 'uint32_t' >> >> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com> >> --- >> fs/jbd2/journal.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> --- linux-next-20090105.orig/fs/jbd2/journal.c >> +++ linux-next-20090105/fs/jbd2/journal.c >> @@ -845,7 +845,8 @@ static int jbd2_seq_info_show(struct seq >> seq_printf(seq, " %ums logging transaction\n", >> jiffies_to_msecs(s->stats->u.run.rs_logging / s->stats->ts_tid)); >> seq_printf(seq, " %luus average transaction commit time\n", >> - do_div(s->journal->j_average_commit_time, 1000)); >> + (unsigned long)do_div(s->journal->j_average_commit_time, >> + 1000)); >> seq_printf(seq, " %lu handles per transaction\n", >> s->stats->u.run.rs_handle_count / s->stats->ts_tid); >> seq_printf(seq, " %lu blocks per transaction\n", > > This patch is just as wrong as the original code. Please don't > apply it, but see my "[PATCH] jbd2: fix wrong use of do_div" > that I just sent out. ok, where did you send it? I don't see it... -- ~Randy ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH -next] jbd2: fix printk format warning 2009-01-11 19:07 ` Randy Dunlap @ 2009-01-11 19:20 ` Simon Holm Thøgersen 0 siblings, 0 replies; 4+ messages in thread From: Simon Holm Thøgersen @ 2009-01-11 19:20 UTC (permalink / raw) To: Randy Dunlap; +Cc: Stephen Rothwell, akpm, linux-next, LKML, linux-ext4 søn, 11 01 2009 kl. 11:07 -0800, skrev Randy Dunlap: > ok, where did you send it? I don't see it... It had a wrong recipient address so it never made it. I've sent it again and verified that it made it this time. Simon ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2009-01-11 19:20 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20090105173517.deeff918.sfr@canb.auug.org.au>
2009-01-05 20:11 ` [PATCH -next] jbd2: fix printk format warning Randy Dunlap
2009-01-11 18:52 ` Simon Holm Thøgersen
2009-01-11 19:07 ` Randy Dunlap
2009-01-11 19:20 ` Simon Holm Thøgersen
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).