From: Eric Sandeen <sandeen@redhat.com>
To: Jan Kara <jack@suse.cz>
Cc: linux-ext4@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, pavel@suse.cz
Subject: Re: [PATCH 2/2] ext2: Add blk_issue_flush() to syncing paths
Date: Wed, 14 Jan 2009 11:47:28 -0600 [thread overview]
Message-ID: <496E2530.4080205@redhat.com> (raw)
In-Reply-To: <20090114174023.GK19950@duck.suse.cz>
Jan Kara wrote:
> On Wed 14-01-09 11:35:50, Eric Sandeen wrote:
>> Jan Kara wrote:
>>> To be really safe that the data hit the platter, we should also flush drive's
>>> writeback caches on fsync and for O_SYNC files or O_DIRSYNC inodes.
>> Seems sane, but aren't we getting really divergent behavior here between
>> ext2, ext3, and ext4 w.r.t. drive cache flushing for sync paths?
> Well, but ext3/4 should do a barrier on a transaction commit (if the user
> really cares about data integrity) and hence it implicitely does the same.
>
> Honza
Sorry, just now catching up with that other thread, which addresses this
topic. :) But yes, this seems correct... (OTOH, I thought SuSE was
carrying a patch which did add this blkdev_flush to sync for ext3...)
-Eric
next prev parent reply other threads:[~2009-01-14 17:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-14 15:12 [PATCH 1/2] ext2: Update also inode on disk when dir is IS_DIRSYNC Jan Kara
2009-01-14 15:12 ` [PATCH 2/2] ext2: Add blk_issue_flush() to syncing paths Jan Kara
2009-01-14 17:35 ` Eric Sandeen
2009-01-14 17:40 ` Jan Kara
2009-01-14 17:47 ` Eric Sandeen [this message]
2009-01-14 18:18 ` Andrew Morton
2009-01-14 18:27 ` Pavel Machek
2009-01-14 22:04 ` Theodore Tso
2009-01-14 22:17 ` Andrew Morton
2009-01-14 22:09 ` Theodore Tso
2009-01-14 22:26 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=496E2530.4080205@redhat.com \
--to=sandeen@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox