* [PATCH] debugfs - fix segfault on "stat" command with no open fs
@ 2009-01-29 22:46 Eric Sandeen
2009-03-08 23:31 ` Theodore Tso
0 siblings, 1 reply; 2+ messages in thread
From: Eric Sandeen @ 2009-01-29 22:46 UTC (permalink / raw)
To: ext4 development; +Cc: Andrew Hecox
This is a regression from commit
8fdf29117f922419bd5b3f741e5d554b1d5b8893, which attempts to access
current_fs via a feature check before we check that it's open.
Just moving the feature check below the open check should fix it.
Reported-by: Andrew Hecox <ahecox@redhat.com>
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---
Index: e2fsprogs/debugfs/debugfs.c
===================================================================
--- e2fsprogs.orig/debugfs/debugfs.c 2008-09-12 10:37:52.000000000 -0500
+++ e2fsprogs/debugfs/debugfs.c 2009-01-29 16:36:04.748574864 -0600
@@ -291,9 +291,6 @@ void do_show_super_stats(int argc, char
int c, header_only = 0;
int numdirs = 0, first, gdt_csum;
- gdt_csum = EXT2_HAS_RO_COMPAT_FEATURE(current_fs->super,
- EXT4_FEATURE_RO_COMPAT_GDT_CSUM);
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] debugfs - fix segfault on "stat" command with no open fs
2009-01-29 22:46 [PATCH] debugfs - fix segfault on "stat" command with no open fs Eric Sandeen
@ 2009-03-08 23:31 ` Theodore Tso
0 siblings, 0 replies; 2+ messages in thread
From: Theodore Tso @ 2009-03-08 23:31 UTC (permalink / raw)
To: Eric Sandeen; +Cc: ext4 development, Andrew Hecox
On Thu, Jan 29, 2009 at 05:46:28PM -0500, Eric Sandeen wrote:
> This is a regression from commit
> 8fdf29117f922419bd5b3f741e5d554b1d5b8893, which attempts to access
> current_fs via a feature check before we check that it's open.
>
> Just moving the feature check below the open check should fix it.
Thanks, applied to the e2fsprogs git tree.
- Ted
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-03-09 3:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-01-29 22:46 [PATCH] debugfs - fix segfault on "stat" command with no open fs Eric Sandeen
2009-03-08 23:31 ` Theodore Tso
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).