From: Thiemo Nagel <thiemo.nagel@ph.tum.de>
To: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
Cc: tytso@mit.edu, linux-ext4@vger.kernel.org
Subject: Re: [PATCH] Add checks to validate extent entries.
Date: Mon, 09 Feb 2009 11:26:12 +0100 [thread overview]
Message-ID: <499004C4.9040305@ph.tum.de> (raw)
In-Reply-To: <1234036882-30656-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com>
Aneesh Kumar K.V wrote:
> This patch adds check to validate the extent entries along
> with extent headers. Should handle crash with corrupt filesystem.
While your patch probably decreases the average number of checks that
are done, it makes single random accesses quite expensive since always
complete extent blocks are checked at once, even if just a single pblock
is accessed. No idea whether there are workloads which have that as a
typical access pattern...
Kind regards,
Thiemo
next prev parent reply other threads:[~2009-02-09 10:26 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-07 15:36 [PATCH] introduce range check for extent pblock references Thiemo Nagel
2009-02-07 17:32 ` Aneesh Kumar K.V
2009-02-07 18:49 ` Thiemo Nagel
2009-02-07 19:59 ` Aneesh Kumar K.V
2009-02-07 20:01 ` [PATCH] Add checks to validate extent entries Aneesh Kumar K.V
2009-02-07 20:01 ` [PATCH] Validate extent details only when read from the disk Aneesh Kumar K.V
2009-02-09 10:31 ` Thiemo Nagel
2009-02-09 10:48 ` Aneesh Kumar K.V
2009-02-09 11:12 ` Thiemo Nagel
2009-02-09 10:26 ` Thiemo Nagel [this message]
2009-02-09 10:31 ` [PATCH] Add checks to validate extent entries Aneesh Kumar K.V
2009-02-09 10:40 ` Thiemo Nagel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=499004C4.9040305@ph.tum.de \
--to=thiemo.nagel@ph.tum.de \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).