Re: [PATCH] Add checks to validate extent entries.

[Thiemo Nagel <thiemo.nagel@ph.tum.de>]

Aneesh Kumar K.V wrote:
> On Mon, Feb 09, 2009 at 11:26:12AM +0100, Thiemo Nagel wrote:
>> Aneesh Kumar K.V wrote:
>>> This patch adds check to validate the extent entries along
>>> with extent  headers. Should handle crash with corrupt filesystem.
>> While your patch probably decreases the average number of checks that
>> are done, it makes single random accesses quite expensive since always
>> complete extent blocks are checked at once, even if just a single pblock
>> is accessed.  No idea whether there are workloads which have that as a
>> typical access pattern...
> 
> The second patch make sure we do it only when we read the extent
> information from the disk.

Imagine a random read of 4k somewhere inside a very large file.  With
your patch, we will loop over several kilobytes of extent tables just
for that single read.  (The second read will be faster, of course, but
who knows whether there will be a second read?)  So I think there exist
some access patterns, for which your patch slows down things
considerably, but I cannot judge whether these are important.

Kind regards,

Thiemo