linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kazuya Mio <k-mio@sx.jp.nec.com>
To: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
Cc: linux-ext4@vger.kernel.org
Subject: Re: double free of blocks occurred during online defrag
Date: Mon, 02 Mar 2009 17:30:51 +0900	[thread overview]
Message-ID: <49AB993B.8050705@sx.jp.nec.com> (raw)
In-Reply-To: <20090225104446.GA25714@skywalker>

Hi Aneesh,

Thanks for your reply.

Aneesh Kumar K.V wrote:
> We dropped the patch because I found that the double free in my case was
> not exactly due the explanation given in the patch above.
> 
> I asked to drop the patch in
> 
> http://article.gmane.org/gmane.comp.file-systems.ext4/10199
> 
> I also found that the patch is not completely correct. The meta-data
> blocks which are added to the free_list are not allocated from any
> prealloc space.
> 
> So what you are seeing may be a different problem which the patch is
> hiding from happening.  I guess you will have to look more closely at why the
> double-free is happening in your case.
> 
> -aneesh
> 

I thought that the problem would be solved if we check whether on-disk and buddy
bitmap is different or not when inode prealloc space is released.
However, my understanding was incorrect.
I will continue examining this problem.

Best regards,
Kazuya Mio

  parent reply	other threads:[~2009-03-02  8:33 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-25  6:39 double free of blocks occurred during online defrag Kazuya Mio
2009-02-25 10:44 ` Aneesh Kumar K.V
2009-02-25 10:59   ` Aneesh Kumar K.V
2009-02-26  9:49     ` Aneesh Kumar K.V
2009-02-26 22:38   ` Mike Snitzer
2009-03-02  8:30   ` Kazuya Mio [this message]
2009-03-06  8:18   ` Kazuya Mio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49AB993B.8050705@sx.jp.nec.com \
    --to=k-mio@sx.jp.nec.com \
    --cc=aneesh.kumar@linux.vnet.ibm.com \
    --cc=linux-ext4@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).