linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Eric Sandeen <sandeen@redhat.com>
To: "Ricardo M. Correia" <Ricardo.M.Correia@Sun.COM>
Cc: "Theodore Ts'o" <tytso@mit.edu>,
	linux-ext4@vger.kernel.org, Andreas Dilger <adilger@Sun.COM>
Subject: Re: [PATCH e2fsprogs] Add ZFS detection to libblkid
Date: Fri, 03 Apr 2009 21:39:00 -0500	[thread overview]
Message-ID: <49D6C844.5070604@redhat.com> (raw)
In-Reply-To: <1212171647.7508.46.camel@localhost>

Ricardo M. Correia wrote:
> This patch adds ZFS filesystem detection to libblkid.
> 
> It probes for VDEV_BOOT_MAGIC in the first 2 ZFS labels in big-endian
> and little-endian formats.
> Unfortunately the probe table doesn't support probing from the end of
> the device, otherwise we could also probe in the 3rd and 4th labels (in
> case the first 2 labels were accidentally overwritten)..
> 
> Eventually we would set the UUID from the ZFS pool GUID and the LABEL tag
> from the pool name, but that requires parsing an XDR encoding of the pool
> configuration which is not trivial.

Hi Ricardo:

I've got a bug on fedora now where a partition w/ zfs on it is being
recognized as ext3.  VDEV_BOOT_MAGIC isn't anywhere in the first 1M of
the device, though an old ext3 superblock is intact.  :(

# hexdump -C sda2-first-1M | grep "0c b1 07 b0 f5 02 00 00"
# hexdump -C sda2-first-1M | grep "00 00 02 f5 b0 07 b1 0c"
#

(so a plea - can you guys change mkfs to zero old signatures?  maybe
256k at the front & end of the device in question?)

there is apparently an uberblock signature in it though:

# hexdump -C sda2-first-1M | grep "0c b1 ba 00"
00015e30  30 e8 ff ff 85 c0 5b 75  48 8b 06 35 0c b1 ba 00

does blkid need more work here, I guess?

Thanks,
-Eric
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2009-04-04  2:39 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-30 18:20 [PATCH e2fsprogs] Add ZFS detection to libblkid Ricardo M. Correia
2008-06-02  7:41 ` Karel Zak
2008-06-02 15:03   ` Ricardo M. Correia
     [not found]   ` <1212418863.7337.34.camel@localhost>
2008-06-02 20:58     ` Karel Zak
2008-06-02 21:38       ` Andreas Dilger
2008-06-02 22:31         ` Karel Zak
2008-06-02 23:11           ` Andreas Dilger
2008-06-03  0:05       ` Theodore Tso
2008-06-03  1:11 ` Theodore Tso
2009-04-04  2:39 ` Eric Sandeen [this message]
2009-04-04 13:04   ` Eric Sandeen
2009-04-04 21:25     ` Andreas Dilger
2009-04-04 21:46       ` Eric Sandeen
2009-04-06  6:25         ` Andreas Dilger
2009-04-06 19:22       ` Ricardo M. Correia
2009-04-06 20:13         ` Eric Sandeen
2009-04-13 19:18           ` Ricardo M. Correia
2009-04-13 19:27             ` Eric Sandeen
2009-04-06 20:35         ` Karel Zak
2009-04-07  7:40         ` Andreas Dilger
2009-04-13 19:29           ` Ricardo M. Correia
2009-04-17  9:51             ` Karel Zak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49D6C844.5070604@redhat.com \
    --to=sandeen@redhat.com \
    --cc=Ricardo.M.Correia@Sun.COM \
    --cc=adilger@Sun.COM \
    --cc=linux-ext4@vger.kernel.org \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).