From: Eric Sandeen <sandeen@redhat.com>
To: nicholas.dokos@hp.com
Cc: linux-ext4@vger.kernel.org, "Theodore Ts'o" <tytso@mit.edu>,
Valerie Aurora <vaurora@redhat.com>
Subject: Re: [PATCH 1/2][64-BIT] blk_t -> blk64_t in read_bitmaps().
Date: Sat, 18 Apr 2009 08:29:16 -0500 [thread overview]
Message-ID: <49E9D5AC.80703@redhat.com> (raw)
In-Reply-To: <30393.1240034704@gamaville.dokosmarshall.org>
Nick Dokos wrote:
> e2fsck -n -f on a brand-new, never-mounted 32TiB filesystem was
> detecting a lot of "Block bitmap differences". This change makes them
> go away (there are are still more problems however: the run finds used
> blocks in one BLOCK_UNINIT group and a free block mismatch.)
>
> Signed-off-by: Nick Dokos <nicholas.dokos@hp.com>
Looks right to me as well.
Reviewed-by: Eric Sandeen <sandeen@redhat.com>
> ---
> lib/ext2fs/rw_bitmaps.c | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/lib/ext2fs/rw_bitmaps.c b/lib/ext2fs/rw_bitmaps.c
> index cee6142..5b504bf 100644
> --- a/lib/ext2fs/rw_bitmaps.c
> +++ b/lib/ext2fs/rw_bitmaps.c
> @@ -144,9 +144,9 @@ static errcode_t read_bitmaps(ext2_filsys fs, int do_inode, int do_block)
> int csum_flag = 0;
> int do_image = fs->flags & EXT2_FLAG_IMAGE_FILE;
> unsigned int cnt;
> - blk_t blk;
> - blk_t blk_itr = fs->super->s_first_data_block;
> - blk_t blk_cnt;
> + blk64_t blk;
> + blk64_t blk_itr = fs->super->s_first_data_block;
> + blk64_t blk_cnt;
> ext2_ino_t ino_itr = 1;
> ext2_ino_t ino_cnt;
>
next prev parent reply other threads:[~2009-04-18 13:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-18 6:05 [PATCH 1/2][64-BIT] blk_t -> blk64_t in read_bitmaps() Nick Dokos
2009-04-18 13:29 ` Eric Sandeen [this message]
2009-04-21 0:49 ` Valerie Aurora Henson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49E9D5AC.80703@redhat.com \
--to=sandeen@redhat.com \
--cc=linux-ext4@vger.kernel.org \
--cc=nicholas.dokos@hp.com \
--cc=tytso@mit.edu \
--cc=vaurora@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).