linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ric Wheeler <rwheeler@redhat.com>
To: Theodore Tso <tytso@mit.edu>
Cc: Eric Sandeen <sandeen@redhat.com>,
	ext4 development <linux-ext4@vger.kernel.org>
Subject: Re: e2fsck -y says "yes" to "Abort?"
Date: Mon, 20 Apr 2009 14:29:28 -0400	[thread overview]
Message-ID: <49ECBF08.6030806@redhat.com> (raw)
In-Reply-To: <20090418161710.GF19186@mit.edu>

Theodore Tso wrote:
> On Sat, Apr 18, 2009 at 09:10:50AM -0500, Eric Sandeen wrote:
>   
>> I've got this bug filed against Fedora:
>>
>> sh-3.2# e2fsck -y /dev/VolGroup00/VolVol02
>> e2fsck 1.41.3 (12-Oct-2008)
>> The filesystem size (according to the superblock) is 14090240 blocks
>> The physical size of the device is 8847360 blocks
>> Either the superblock or the partition table is likely to be corrupt!
>>
>> Abort? yes
>>
>> I'm reluctant to invert the logic of the Abort? question as suggested
>> ("Are you sure you want to continue?") because this is a significant
>> enough problem that we probably should really pause for consideration.
>>
>> But it seems like perhaps stopping at "Abort?", allowing the user to say
>> "n" to that and then let the "-y" flag take over from there would be
>> reasonable.
>>
>> If this sounds ok I'll whip up a patch, something like a way to flag the
>> really serious questions (?) as unaffected by -y.
>>     
>
> Seems reasonable to me; we'll have to update the documentation to
> explain that -y really doesn't mean yes to _all_ questions, but that
> seems like the best approach.
>
> 					- Ted
> --
>   

The only down side is when you try to automate this (say in an 
appliance) and you don't have a human reading the output. In this case, 
you might just want to invert the logic but in general, it does seem 
dangerous to invert the logic for a long standing option,

Ric


  reply	other threads:[~2009-04-20 18:29 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-18 14:10 e2fsck -y says "yes" to "Abort?" Eric Sandeen
2009-04-18 16:17 ` Theodore Tso
2009-04-20 18:29   ` Ric Wheeler [this message]
2009-04-20 18:33     ` Eric Sandeen
2009-04-20 18:38       ` Ric Wheeler
2009-04-20 20:47         ` Andreas Dilger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49ECBF08.6030806@redhat.com \
    --to=rwheeler@redhat.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=sandeen@redhat.com \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).