From: Eric Sandeen <sandeen@redhat.com>
To: Theodore Tso <tytso@mit.edu>
Cc: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>,
cmm@us.ibm.com, linux-ext4@vger.kernel.org
Subject: Re: [PATCH -V4 2/2] ext4: Use -1 as the fake block number for delayed new buffer_head
Date: Wed, 29 Apr 2009 10:37:34 -0500 [thread overview]
Message-ID: <49F8743E.7090201@redhat.com> (raw)
In-Reply-To: <20090429153521.GC14264@mit.edu>
Theodore Tso wrote:
> On Wed, Apr 29, 2009 at 10:17:21AM +0530, Aneesh Kumar K.V wrote:
>> Block number '0' should not be used as the fake block number for
>> the delayed new buffer. This will result in vfs calling umap_underlying_metadata for
>> block number '0'. So use -1 instead.
>
> sector_t is an unsigned type, so we probably want to use ~0 instead of
> -1. I can fix this up before we apply into the patch queue.
I don't think that helps. The point is to have a block number which is
invalid, therefore won't get unmapped or accidentally written to ...
-Eric
> Are we agreed both of these should probably be pushed to Linus for
> 2.6.30?
>
> - Ted
next prev parent reply other threads:[~2009-04-29 15:37 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-29 4:47 [PATCH -V4 1/2] Fix sub-block zeroing for buffered writes into unwritten extents Aneesh Kumar K.V
2009-04-29 4:47 ` [PATCH -V4 2/2] ext4: Use -1 as the fake block number for delayed new buffer_head Aneesh Kumar K.V
2009-04-29 13:59 ` Eric Sandeen
2009-04-29 15:35 ` Theodore Tso
2009-04-29 15:37 ` Eric Sandeen [this message]
2009-04-29 16:52 ` Theodore Tso
2009-04-29 17:01 ` Eric Sandeen
2009-05-04 8:54 ` Aneesh Kumar K.V
2009-05-04 15:06 ` Eric Sandeen
2009-05-12 15:17 ` [PATCH -V5] " Aneesh Kumar K.V
2009-04-29 13:59 ` [PATCH -V4 1/2] Fix sub-block zeroing for buffered writes into unwritten extents Eric Sandeen
2009-04-29 17:28 ` Mingming
2009-05-12 2:42 ` Theodore Tso
2009-05-12 3:37 ` Eric Sandeen
2009-05-12 15:16 ` [PATCH -V5] Fix sub-block zeroing for buffered writes intounwritten extents Aneesh Kumar K.V
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49F8743E.7090201@redhat.com \
--to=sandeen@redhat.com \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=cmm@us.ibm.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).