linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ric Wheeler <rwheeler@redhat.com>
To: Theodore Tso <tytso@mit.edu>
Cc: "Greg Freemyer" <greg.freemyer@gmail.com>,
	"Jörn Engel" <joern@logfs.org>,
	"Matthew Wilcox" <willy@linux.intel.com>,
	"Jens Axboe" <jens.axboe@oracle.com>,
	linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org,
	"Linux RAID" <linux-raid@vger.kernel.org>
Subject: Re: Is TRIM/DISCARD going to be a performance problem?
Date: Mon, 11 May 2009 10:29:51 -0400	[thread overview]
Message-ID: <4A08365F.5040805@redhat.com> (raw)
In-Reply-To: <20090511142740.GC6277@mit.edu>

On 05/11/2009 10:27 AM, Theodore Tso wrote:
> On Mon, May 11, 2009 at 09:10:15AM -0400, Greg Freemyer wrote:
>> That implies that the SSD folks are not treating erase blocks as a
>> contiguous group of sectors.
>
> Correct.
>
>> For some reason, I thought their was
>> only one mapping per erase block and within the erase block the
>> sectors were contiguous..
>
> No, if you try to treat erase blocks as a contiguous group of
> sectors, you'll have terrible write amplification problems (leading to
> premature death of the SSD) and terrible small random write
> performance.  Flash devices optimized for digital cameras might have
> done that, but for SSD's, this will result in catastrophically bad
> performance, and very limited lifespan.  As I said, I expect these
> SSD's to be weeded out of the market very shortly.
>
> For any sane implementation of an SSD, the mapping will be on a per
> LBA basis, not on a per-erase block basis.
>
>> More realistic is to figure out a way to make it deterministic at
>> least for the short term (by writing data to all the trimmed blocks?),
>> then reshaping, then having a tool to scan the filesystem and re-issue
>> all the trim commands.
>
> Writing data to all of the trimmed block?  Um, no.  That would be a
> diaster, since it accelerates the wear and tear of the SSD.  The whole
> *point* of the TRIM command is to avoid needing to do that.
>
> The whole worry about determinism is highly overrated.  If the
> filesystem doesn't need a block, then it doesn't need it.  What you
> read after you send a TRIM command, whether it is the old data because
> the device applied some kind of rounding, or random data, or all
> zero's, won't matter to the filesystem.  Why should the filesystem
> care?  I know I certainly don't....
>
> 					- Ted


The key is not at the FS layer - this is an issue for people who RAID these 
beasts together and want to actually check that the bits are what they should be 
(say doing a checksum validity check for a stripe).

ric


  reply	other threads:[~2009-05-11 14:29 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-09 21:14 Is TRIM/DISCARD going to be a performance problem? Theodore Ts'o
2009-05-10 16:53 ` Jörn Engel
2009-05-11  8:37   ` Theodore Tso
2009-05-11 10:06     ` Jörn Engel
2009-05-11 10:18       ` Jens Axboe
2009-05-11 15:43         ` Jeff Garzik
2009-05-11 11:27       ` Theodore Tso
2009-05-11 12:09         ` Theodore Tso
2009-05-11 13:10           ` Greg Freemyer
2009-05-11 13:39             ` Matthew Wilcox
2009-05-11 14:27             ` Theodore Tso
2009-05-11 14:29               ` Ric Wheeler [this message]
2009-05-11 14:50                 ` Theodore Tso
2009-05-11 14:58                   ` Ric Wheeler
2009-05-11 15:00                   ` Matthew Wilcox
2009-05-11 18:47                     ` Greg Freemyer
2009-05-11 19:22                       ` Andreas Dilger
2009-05-11 23:38                       ` Neil Brown
2009-05-12 13:28                         ` Greg Freemyer
2009-05-11 13:15           ` Ric Wheeler
2010-04-24 17:11           ` Phillip Susi
2009-05-11 12:43         ` Jörn Engel
2009-05-11 12:48           ` Matthew Wilcox
     [not found]             ` <f3177b9e0905111433i40e41c90r920d7ccf36442ffd@mail.gmail.com>
2009-05-11 22:03               ` Chris Worley
2009-05-11 16:30       ` Chris Worley
2009-05-11  8:12 ` Jens Axboe
2009-05-11  8:41   ` Theodore Tso
2009-05-11  8:49     ` Jens Axboe
2009-05-11 17:18     ` Chris Mason
2009-05-11 18:43       ` Matthew Wilcox
2009-05-11 18:53         ` Chris Mason
2009-05-11 19:19           ` Theodore Tso
2009-05-29 10:52         ` Florian Weimer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A08365F.5040805@redhat.com \
    --to=rwheeler@redhat.com \
    --cc=greg.freemyer@gmail.com \
    --cc=jens.axboe@oracle.com \
    --cc=joern@logfs.org \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-raid@vger.kernel.org \
    --cc=tytso@mit.edu \
    --cc=willy@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).