Re: [PATCH] EXT3: Change all super.c messages to print the device

[Eric Sandeen <sandeen@redhat.com>]

Theodore Tso wrote:
> On Tue, May 19, 2009 at 07:14:30PM +0200, Jan Kara wrote:
>>> EXT3: Change all super.c messages to print the device
>>>
>>> I had a problem where it was unclear to which device a ext3 message belonged.
>>> Not all of them them print it.
>>>
>>> This patch changes ext3 super.c to include the device name with all 
>>> warning/error messages, by using a new utility function ext3_msg. 
>>> It's a rather large patch, but very mechanic. I left debug printks
>>> alone.
>>>
>>> The normal mount output looks a little more regular now because near all
>>> messages are in the same format.
>>>
>>> Signed-off-by: Andi Kleen <ak@linux.intel.com>
>>   Ted, did you pick up this cleanup? I don't see any reply or the patch
>> being merged... The cleanup looks nice.
> 
> No, I didn't but thanks for reminding me; I agree it's a good cleanup.
> We should get it ported over to ext4, too.

I'll do that, unless anyone's already started.

There's a bit of inconsistency in the patch between:

ext3_msg(sb, KERN_ERR "message");
and
ext3_msg(sb, KERN_ERR, "message");

just FWIW.

-Eric