From: Eric Sandeen <sandeen@redhat.com>
To: ext4 development <linux-ext4@vger.kernel.org>
Subject: [PATCH V2] libext2fs: reset handle after inserting new extent
Date: Tue, 07 Jul 2009 14:30:32 -0500 [thread overview]
Message-ID: <4A53A258.20105@redhat.com> (raw)
In-Reply-To: <4A52776B.8000203@redhat.com>
Commit 53422e8a5644e22ea3f6e0efba82a765b72e4308 moved
the new extent insertion in ext2fs_extent_set_bmap prior
to the modification of the original extent, but the
insert function left the handle pointing a the new
extent; this left us modifying the -new- extent not
the original one, and winding up with a corrupt extent
tree something like:
BLOCKS:
(0-1):588791-588792, (0):588791
We need to move back to the previous extent prior
to modification, if we inserted a new one.
V2: Use extent_goto vs. extent_get.
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---
diff --git a/lib/ext2fs/extent.c b/lib/ext2fs/extent.c
index 35b080e..4a4fd2c 100644
--- a/lib/ext2fs/extent.c
+++ b/lib/ext2fs/extent.c
@@ -1257,6 +1257,10 @@ again:
EXT2_EXTENT_INSERT_AFTER, &newextent);
if (retval)
goto done;
+ /* Now pointing at inserted extent; move back to prev */
+ retval = ext2fs_extent_goto(handle, logical - 1);
+ if (retval)
+ goto done;
}
extent.e_len--;
retval = ext2fs_extent_replace(handle, 0, &extent);
prev parent reply other threads:[~2009-07-07 19:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-06 22:15 [PATCH] libext2fs: reset handle after inserting new extent Eric Sandeen
2009-07-07 13:35 ` Theodore Tso
2009-07-07 14:22 ` Eric Sandeen
2009-07-07 19:30 ` Eric Sandeen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A53A258.20105@redhat.com \
--to=sandeen@redhat.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).