From: Eric Sandeen <sandeen@redhat.com>
To: Peng Tao <bergwolf@gmail.com>
Cc: linux-ext4@vger.kernel.org, tytso@mit.edu
Subject: Re: [PATCH 5/5] Makefile.in: allow make install e4defrag
Date: Sun, 19 Jul 2009 16:37:44 -0500 [thread overview]
Message-ID: <4A639228.9090905@redhat.com> (raw)
In-Reply-To: <1248025714-25954-1-git-send-email-bergwolf@gmail.com>
Peng Tao wrote:
> Current Makefile does not install e4defrag nor e4defrag.8.
> Change misc/Makefile.in to make the e4defrag available for use.
>
> Signed-off-by: Peng Tao <bergwolf@gmail.com>
Since this is all still fairly developmental at this point (I think?)
perhaps a special "make install-e4defrag" target might be best.
Otherwise packages which "make install" will start shipping e4defrag,
and I'm not sure we want to do that quite yet.
-Eric
> ---
> misc/Makefile.in | 7 ++++---
> 1 files changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/misc/Makefile.in b/misc/Makefile.in
> index 5f5dab5..4cfeb69 100644
> --- a/misc/Makefile.in
> +++ b/misc/Makefile.in
> @@ -28,10 +28,11 @@ SPROGS= mke2fs badblocks tune2fs dumpe2fs $(BLKID_PROG) logsave \
> USPROGS= mklost+found filefrag $(UUIDD_PROG)
> SMANPAGES= tune2fs.8 mklost+found.8 mke2fs.8 dumpe2fs.8 badblocks.8 \
> e2label.8 $(FINDFS_MAN) $(BLKID_MAN) $(E2IMAGE_MAN) \
> - logsave.8 filefrag.8 e2undo.8 $(UUIDD_MAN) @FSCK_MAN@
> + logsave.8 filefrag.8 e2undo.8 $(UUIDD_MAN) @FSCK_MAN@ \
> + e4defrag.8
> FMANPAGES= mke2fs.conf.5
>
> -UPROGS= chattr lsattr @UUID_CMT@ uuidgen
> +UPROGS= chattr lsattr @UUID_CMT@ uuidgen e4defrag
> UMANPAGES= chattr.1 lsattr.1 @UUID_CMT@ uuidgen.1
>
> LPROGS= @E2INITRD_PROG@
> @@ -99,7 +100,7 @@ COMPILE_ET=$(top_builddir)/lib/et/compile_et --build-tree
> @PROFILE_CMT@ $(Q) $(CC) $(ALL_CFLAGS) -g -pg -o profiled/$*.o -c $<
>
> all:: profiled $(SPROGS) $(UPROGS) $(USPROGS) $(SMANPAGES) $(UMANPAGES) \
> - $(FMANPAGES) $(LPROGS) e4defrag
> + $(FMANPAGES) $(LPROGS)
>
> @PROFILE_CMT@all:: tune2fs.profiled blkid.profiled e2image.profiled \
> e2undo.profiled mke2fs.profiled dumpe2fs.profiled fsck.profiled \
next prev parent reply other threads:[~2009-07-19 21:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-19 17:48 [PATCH 5/5] Makefile.in: allow make install e4defrag Peng Tao
2009-07-19 18:02 ` Peng Tao
2009-07-19 21:37 ` Eric Sandeen [this message]
2009-07-20 4:21 ` Peng Tao
2009-07-20 14:52 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A639228.9090905@redhat.com \
--to=sandeen@redhat.com \
--cc=bergwolf@gmail.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).