From: Eric Sandeen <sandeen@redhat.com>
To: Peng Tao <bergwolf@gmail.com>
Cc: linux-ext4@vger.kernel.org, tytso@mit.edu
Subject: Re: [PATCH 5/5] Makefile.in: allow make install e4defrag
Date: Mon, 20 Jul 2009 09:52:50 -0500 [thread overview]
Message-ID: <4A6484C2.9090802@redhat.com> (raw)
In-Reply-To: <4A63F0B1.7090002@gmail.com>
Peng Tao wrote:
> From 248322ee72e371dcd1b302400d787f9f2eec15cd Mon Sep 17 00:00:00 2001
> From: Peng Tao <bergwolf@gmail.com>
> Date: Mon, 20 Jul 2009 12:01:55 +0800
> Subject: [PATCH-e2fsprogs] Makefile.in: add install-e4defrag target
>
> The e4defrag program is still developmental, but we can make it available
> for use if someone wants to test it.
>
> Signed-off-by: Peng Tao <bergwolf@gmail.com>
I like this better, thanks! I'll ask on the ext4 call today if others
concur.
-Eric
> ---
> Makefile.in | 3 +++
> misc/Makefile.in | 6 +++++-
> 2 files changed, 8 insertions(+), 1 deletions(-)
>
> diff --git a/Makefile.in b/Makefile.in
> index 45f2972..1c2b44e 100644
> --- a/Makefile.in
> +++ b/Makefile.in
> @@ -57,6 +57,9 @@ clean-doc:
> distclean-doc:
> -test -d doc && cd doc && $(MAKE) distclean
>
> +install-e4defrag: subs all-libs-recursive
> + $(MAKE) -C misc install-e4defrag
> +
> install: subs all-libs-recursive install-progs-recursive \
> install-shlibs-libs-recursive install-doc-libs
> if test ! -d e2fsck && test ! -d debugfs && test ! -d misc && test ! -d ext2ed ; then $(MAKE) install-libs ; fi
> diff --git a/misc/Makefile.in b/misc/Makefile.in
> index 5f5dab5..029a201 100644
> --- a/misc/Makefile.in
> +++ b/misc/Makefile.in
> @@ -399,6 +399,10 @@ installdirs:
> $(DESTDIR)$(man1dir) $(DESTDIR)$(man5dir) \
> $(DESTDIR)$(libdir) $(DESTDIR)/$(root_sysconfdir)
>
> +install-e4defrag: e4defrag e4defrag.8 installdirs
> + $(INSTALL_PROGRAM) e4defrag $(DESTDIR)$(bindir)/e4defrag
> + $(INSTALL_DATA) e4defrag.8 $(DESTDIR)$(man8dir)/e4defrag.8
> +
> install: all $(SMANPAGES) $(UMANPAGES) installdirs
> $(Q) for i in $(SPROGS); do \
> echo " INSTALL $(root_sbindir)/$$i"; \
> @@ -556,7 +560,7 @@ clean:
> blkid.profiled tune2fs.profiled e2image.profiled \
> e2undo.profiled mke2fs.profiled dumpe2fs.profiled \
> logsave.profiled filefrag.profiled uuidgen.profiled \
> - uuidd.profiled e2image.profiled \
> + uuidd.profiled e2image.profiled e4defrag \
> profiled/*.o \#* *.s *.o *.a *~ core gmon.out
>
> mostlyclean: clean
prev parent reply other threads:[~2009-07-20 14:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-19 17:48 [PATCH 5/5] Makefile.in: allow make install e4defrag Peng Tao
2009-07-19 18:02 ` Peng Tao
2009-07-19 21:37 ` Eric Sandeen
2009-07-20 4:21 ` Peng Tao
2009-07-20 14:52 ` Eric Sandeen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A6484C2.9090802@redhat.com \
--to=sandeen@redhat.com \
--cc=bergwolf@gmail.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).