From: Eric Sandeen <sandeen@redhat.com>
To: Justin Maggard <jmaggard10@gmail.com>
Cc: Andreas Dilger <adilger@sun.com>,
ext4 development <linux-ext4@vger.kernel.org>,
"Theodore Ts'o" <tytso@mit.edu>
Subject: Re: [PATCH] libext2fs: use ext2fs_blocks_count() in ext2fs_open2()
Date: Wed, 02 Sep 2009 11:43:10 -0500 [thread overview]
Message-ID: <4A9EA09E.10509@redhat.com> (raw)
In-Reply-To: <150c16850909012305y2481c54fra671b123780caa80@mail.gmail.com>
Justin Maggard wrote:
> On Tue, Sep 1, 2009 at 10:59 PM, Andreas Dilger<adilger@sun.com> wrote:
>> On Sep 01, 2009 16:43 -0500, Eric Sandeen wrote:
>>> ext2fs_open2() was only looking at s_blocks_count, and
>>> when it wrapped to a low number, it was failing the test of:
>>>
>>> fs->super->s_first_data_block >= fs->super->s_blocks_count
>>>
>>> which made the superblock look corrupt.
>> Is this the source of the "e2fsck is finding bad checksums" problem?
>
> I applied this earlier today, and it didn't appear to help in my test case.
>
> -Justin
Nah, didn't expect it to, but I'm working towards that. Just have to
whack down the bugs between where I am, and your bug ;)
-Eric
next prev parent reply other threads:[~2009-09-02 16:43 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-01 21:43 [PATCH] libext2fs: use ext2fs_blocks_count() in ext2fs_open2() Eric Sandeen
2009-09-02 5:59 ` Andreas Dilger
2009-09-02 6:05 ` Justin Maggard
2009-09-02 16:43 ` Eric Sandeen [this message]
2009-09-02 21:02 ` Nick Dokos
2009-09-02 21:28 ` Justin Maggard
2009-09-02 21:31 ` Eric Sandeen
2009-09-02 21:37 ` Nick Dokos
2009-09-02 21:43 ` Eric Sandeen
2009-09-02 21:45 ` Justin Maggard
2009-09-02 22:33 ` Eric Sandeen
2009-09-02 22:55 ` Andreas Dilger
2009-09-03 2:41 ` Eric Sandeen
2009-09-02 22:28 ` Theodore Tso
2009-09-02 23:12 ` Nick Dokos
2009-09-06 16:37 ` [PATCH] Fix counting routines in blknum.c to take/return __u32 counts Theodore Tso
2009-09-06 17:41 ` Nick Dokos
2009-09-06 18:19 ` Theodore Tso
2009-09-06 16:30 ` [PATCH] libext2fs: use ext2fs_blocks_count() in ext2fs_open2() Theodore Tso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A9EA09E.10509@redhat.com \
--to=sandeen@redhat.com \
--cc=adilger@sun.com \
--cc=jmaggard10@gmail.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).