Re: [PATCH 0/3][RFC] add a message in mount/remount/umount for ext2/ext3/ext4

[Eric Sandeen <sandeen@redhat.com>]

Toshiyuki Okajima wrote:
> Hi Ted, Andrew and all.
> 
> Under the current implementation, we cannot know in the system log 
> (/var/log/messages) when the filesystem (ext2/ext3/ext4) is unmounted.
> For enterprise users, they often want to observe certain filesystems'
> actions (mount/unmount) in the system log. Besides, by the system log, 
> we occasionally wants to know whether a certain filesystem has been
> unmounted or not at the time when a problem happens.
> 
> The following patch series implement above demand. 
> Please apply it.

If this is really a common requirement, perhaps we should at least
consider putting it in the vfs, in  vfs_kern_mount(),
generic_shutdown_super(), and do_remount_sb().

That way we'll have common behavior and less replicated code; nothing in
this patch series is unique to ext[234] as far as I can tell.

sb->s_type->name could be used to print the fs type in a generic message.

-Eric

> Signed-off-by: Toshiyuki Okajima <toshi.okajima@jp.fujitsu.com>
> ---
>  fs/ext2/super.c |   16 ++++++++++++++++
>  fs/ext3/super.c |   32 +++++++++++++++++++++++---------
>  fs/ext4/super.c |   30 ++++++++++++++++++++++--------
>  3 files changed, 61 insertions(+), 17 deletions(-)
> 
> Regards,
> Toshiyuki Okajima
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html