From: Eric Sandeen <sandeen@redhat.com>
To: ext4 development <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH] debugfs: open with EXT2_FLAG_64BITS
Date: Thu, 08 Oct 2009 15:17:00 -0500 [thread overview]
Message-ID: <4ACE48BC.7010505@redhat.com> (raw)
In-Reply-To: <4AAA6A44.90902@redhat.com>
Eric Sandeen wrote:
> Pointing debugfs from the pu branch at a large filesystem is
> still failing with:
>
> Filesystem too large to use legacy bitmaps while reading block bitmap
>
> We need to open with EXT2_FLAG_64BITS; I'm not sure if this
> should be a switch based on the size of the fs or not?
>
> But in any case the below gets things moving enough to
> use debugfs on a large filesystem.
ping?
Thanks,
-Eric
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
> ---
>
> diff --git a/debugfs/debugfs.c b/debugfs/debugfs.c
> index 3bb309f..fbebae7 100644
> --- a/debugfs/debugfs.c
> +++ b/debugfs/debugfs.c
> @@ -127,7 +127,7 @@ void do_open_filesys(int argc, char **argv)
> int catastrophic = 0;
> blk64_t superblock = 0;
> blk64_t blocksize = 0;
> - int open_flags = EXT2_FLAG_SOFTSUPP_FEATURES;
> + int open_flags = EXT2_FLAG_SOFTSUPP_FEATURES | EXT2_FLAG_64BITS;
> char *data_filename = 0;
>
> reset_getopt();
> @@ -2148,7 +2148,7 @@ int main(int argc, char **argv)
> int sci_idx;
> const char *usage = "Usage: %s [-b blocksize] [-s superblock] [-f cmd_file] [-R request] [-V] [[-w] [-c] device]";
> int c;
> - int open_flags = EXT2_FLAG_SOFTSUPP_FEATURES;
> + int open_flags = EXT2_FLAG_SOFTSUPP_FEATURES | EXT2_FLAG_64BITS;
> char *request = 0;
> int exit_status = 0;
> char *cmd_file = 0;
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2009-10-08 20:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-11 15:18 [PATCH] debugfs: open with EXT2_FLAG_64BITS Eric Sandeen
2009-09-12 20:29 ` Andreas Dilger
2009-10-08 20:17 ` Eric Sandeen [this message]
2009-10-26 5:15 ` Theodore Tso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ACE48BC.7010505@redhat.com \
--to=sandeen@redhat.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).