From: Akira Fujita <a-fujita@rs.jp.nec.com>
To: Peng Tao <bergwolf@gmail.com>
Cc: ext4 development <linux-ext4@vger.kernel.org>,
Kazuya Mio <k-mio@sx.jp.nec.com>, "Theodore Ts'o" <tytso@mit.edu>
Subject: Re: donor file data inconsistent after EXT4_IOC_MOVE_EXT
Date: Mon, 19 Oct 2009 17:28:57 +0900 [thread overview]
Message-ID: <4ADC2349.6030304@rs.jp.nec.com> (raw)
In-Reply-To: <4ADBFC4D.8050405@gmail.com>
Hi Peng,
Peng Tao wrote:
> Hi, Akira,
>
> Peng Tao wrote:
>> Hi, Akira,
>> Akira Fujita wrote:
>>> Hi Peng,
>>>
>>> This is a known issue, and I sent a patch to linux-ext4 2 weeks ago.
>>> Unfortunately it is not included in the ext4 patch queue yet.
>>>
>>> http://marc.info/?l=linux-ext4&m=125447192709338&w=2
>>>
>>> Would you retry your test case with above my patch?
>> It didn't work. I still got the old donor file data.
> invalidate_mapping_pages() in your patch won't invalidate the locked page returned by
> grab_cache_page(). The following patch addresses the bug by calling
> invalidate_inode_pages2_range() instead.
Though I tested my patch, I seem to have made a mistake.
Anyway, I confirmed your patch works fine, thank you.
Regards,
Akira Fujita
prev parent reply other threads:[~2009-10-19 8:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-18 7:03 donor file data inconsistent after EXT4_IOC_MOVE_EXT Peng Tao
2009-10-19 0:40 ` Akira Fujita
2009-10-19 2:28 ` Peng Tao
2009-10-19 5:42 ` Peng Tao
2009-10-19 8:28 ` Akira Fujita [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ADC2349.6030304@rs.jp.nec.com \
--to=a-fujita@rs.jp.nec.com \
--cc=bergwolf@gmail.com \
--cc=k-mio@sx.jp.nec.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox