From: Eric Sandeen <sandeen@redhat.com>
To: Julia Lawall <julia@diku.dk>
Cc: linux-ext4@vger.kernel.org, Mingming Cao <cmm@us.ibm.com>
Subject: Re: question about ext4/inode.c
Date: Mon, 02 Nov 2009 11:48:09 -0600 [thread overview]
Message-ID: <4AEF1B59.2070702@redhat.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0911021708550.2115@ask.diku.dk>
Julia Lawall wrote:
> The function ext4_da_writepages_trans_blocks contains the following code:
>
> if (!(inode->i_flags & EXT4_EXTENTS_FL) &&
> (max_blocks > EXT4_MAX_TRANS_DATA))
> max_blocks = EXT4_MAX_TRANS_DATA;
>
>
> Elsewhere the constant EXT4_EXTENTS_FL is used as follows:
>
> EXT4_I(inode)->i_flags & EXT4_EXTENTS_FL
>
> Should that be done in ext4_da_writepages_trans_blocks as well?
>
> thanks,
> julia
Ouch, yes, looks like a bug. I don't think that value would ever be set
on the vfs inode's i_flags so we're always going down that path.
It's probably not catastrophic; if I'm reading it right we are just
being more conservative all the time.
Want to send a patch? :)
-Eric
prev parent reply other threads:[~2009-11-02 17:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-02 16:10 question about ext4/inode.c Julia Lawall
2009-11-02 17:48 ` Eric Sandeen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AEF1B59.2070702@redhat.com \
--to=sandeen@redhat.com \
--cc=cmm@us.ibm.com \
--cc=julia@diku.dk \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox