From: Eric Sandeen <sandeen@redhat.com>
To: "Theodore Ts'o" <tytso@mit.edu>
Cc: Ext4 Developers List <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH 0/8] Clean up ext4's block free code paths
Date: Sun, 22 Nov 2009 21:53:16 -0600 [thread overview]
Message-ID: <4B0A072C.5000305@redhat.com> (raw)
In-Reply-To: <1258942710-31930-1-git-send-email-tytso@mit.edu>
Theodore Ts'o wrote:
> This patch series cleans up functions involved with freeing blocks. It
> removes functions that are only called by a single caller and folds them
> into their caller, and makes the code a little easier to read. It also
> reduces ext4's code foot print slightly (by 136 bytes).
>
> Finally, it fixes a bug in the extents migration function, which was
> missing calls to ext4_forget() when it frees the indirect blocks after
> converting an inode to using extents. This avoids potential file system
> corruption after a crash while converting an entire filesystem to use
> extents via "chattr -R +e /mntpt".
Have you double-checked stack usage before & after the series, just
in case all the folding-in increased some stack footprints?
Probably ok, but worth a double-check.
-Eric
> - Ted
>
> Theodore Ts'o (8):
> ext4: move ext4_forget() to ext4_jbd2.c
> ext4: fold ext4_journal_revoke() into ext4_forget()
> ext4: fold ext4_journal_forget() into ext4_forget()
> ext4: fold ext4_free_blocks() and ext4_mb_free_blocks()
> ext4: call ext4_forget() from ext4_free_blocks()
> ext4: print i_mode in octal in ext4 tracepoints
> ext4: add check for wraparound in ext4_data_block_valid()
> ext4: use ext4_data_block_valid() in ext4_free_blocks()
>
> fs/ext4/balloc.c | 38 --------------
> fs/ext4/block_validity.c | 1 +
> fs/ext4/ext4.h | 15 +++--
> fs/ext4/ext4_jbd2.c | 82 ++++++++++++++++++++++---------
> fs/ext4/ext4_jbd2.h | 23 +++------
> fs/ext4/extents.c | 24 +++------
> fs/ext4/inode.c | 116 +++++++++++--------------------------------
> fs/ext4/mballoc.c | 61 ++++++++++++++++++-----
> fs/ext4/migrate.c | 23 ++++++---
> fs/ext4/xattr.c | 8 ++-
> include/trace/events/ext4.h | 24 +++++----
> 11 files changed, 198 insertions(+), 217 deletions(-)
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2009-11-23 3:53 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-23 2:18 [PATCH 0/8] Clean up ext4's block free code paths Theodore Ts'o
2009-11-23 2:18 ` [PATCH 1/8] ext4: move ext4_forget() to ext4_jbd2.c Theodore Ts'o
2009-11-23 2:18 ` [PATCH 2/8] ext4: fold ext4_journal_revoke() into ext4_forget() Theodore Ts'o
2009-11-23 2:18 ` [PATCH 3/8] ext4: fold ext4_journal_forget() " Theodore Ts'o
2009-11-23 2:18 ` [PATCH 4/8] ext4: fold ext4_free_blocks() and ext4_mb_free_blocks() Theodore Ts'o
2009-11-23 2:18 ` [PATCH 5/8] ext4: call ext4_forget() from ext4_free_blocks() Theodore Ts'o
2009-11-23 19:22 ` Andreas Dilger
2009-11-23 20:28 ` tytso
2009-11-23 2:18 ` [PATCH 6/8] ext4: print i_mode in octal in ext4 tracepoints Theodore Ts'o
2009-11-23 2:18 ` [PATCH 7/8] ext4: add check for wraparound in ext4_data_block_valid() Theodore Ts'o
2009-11-23 2:18 ` [PATCH 8/8] ext4: use ext4_data_block_valid() in ext4_free_blocks() Theodore Ts'o
2009-11-23 3:53 ` Eric Sandeen [this message]
2009-11-23 14:46 ` [PATCH 0/8] Clean up ext4's block free code paths tytso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B0A072C.5000305@redhat.com \
--to=sandeen@redhat.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).