linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Eric Sandeen <sandeen@redhat.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Michal Novotny <minovotn@redhat.com>,
	Ric Wheeler <rwheeler@redhat.com>,
	linux-ext4@vger.kernel.org
Subject: Re: [PATCH] extend e2fsprogs functionality to add EXT2_FLAG_DIRECT option
Date: Tue, 12 Jan 2010 09:16:20 -0600	[thread overview]
Message-ID: <4B4C9244.2050704@redhat.com> (raw)
In-Reply-To: <20100112122319.GA20596@infradead.org>

Christoph Hellwig wrote:
> On Tue, Jan 12, 2010 at 01:15:49PM +0100, Michal Novotny wrote:
>> I don't really know if I see your point but the thing here is that there  
>> was no way to open a file directly (ie. using O_DIRECT). The direct  
>> write support has been added only to make it possible to use both read  
>> and write directly. The main reason to create this patch was to add  
>> direct read support and flush capability won't help me at all. I am  
>> working in Red Hat, Virtualization team on Xen so I am really not that  
>> much familiar with file systems but what I needed was an option to read  
>> the data directly (using O_DIRECT) in e2fsprogs. One bug was about  
>> pygrub (Python version of GRUB of Xen PV guests that is internally using  
>> e2fsprogs functionality to access data on ext2/3/4 partition to boot the  
>> PV guests) uses outdated/cached data so some modifications were  
>> necessary to open everything directly...
> 
> So to get things staigt:  you're using e2fsprogs to manipulate a life
> filesystem and thing using O_DIRECT saves your ass?  I think you need to
> rething your model of operation fundamentally in that case. 
> 

Christoph - 

It's my understanding that nobody is doing concurrent access.

If the host reads the block device via pygrub to boot the guest,
the guest while running updates the same device when installing
a new kernel (either through the fs, or by writing to the bdev;
probably the former...), and then the guest shuts down - is there
something which will sync the host's cache (cached from the
prior read) with the updates from the guest?

I don't know nearly enough about how the virt IO goes ...

But if access is sequential between host & guest, I'd hope that
this would all just work.

If that is all supposed to work, then maybe the description of the
data flow (as Ric asked for) is not correct.

-Eric

  parent reply	other threads:[~2010-01-12 15:16 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-08  9:36 [PATCH] extend e2fsprogs functionality to add EXT2_FLAG_DIRECT option Michal Novotny
2010-01-11 20:06 ` Ric Wheeler
2010-01-12 10:54   ` Michal Novotny
2010-01-12 11:59     ` Ric Wheeler
2010-01-12 12:15       ` Michal Novotny
2010-01-12 12:23         ` Christoph Hellwig
2010-01-12 12:30           ` Michal Novotny
2010-01-12 12:46             ` Christoph Hellwig
2010-01-12 13:01               ` Michal Novotny
2010-01-12 13:04                 ` Ric Wheeler
2010-01-12 13:12                   ` Michal Novotny
2010-01-12 13:23                     ` Michal Novotny
2010-01-12 13:29                       ` Ric Wheeler
2010-01-12 13:33                         ` Michal Novotny
2010-01-12 14:33                           ` Chris Lee
2010-01-12 14:37                             ` Michal Novotny
2010-01-12 16:38                 ` Christoph Hellwig
2010-01-12 16:43                   ` Michal Novotny
2010-01-12 16:47                     ` Christoph Hellwig
2010-01-12 16:51                       ` Michal Novotny
2010-01-12 16:50                     ` Ric Wheeler
2010-01-12 16:53                       ` Michal Novotny
2010-01-12 16:56                         ` Eric Sandeen
2010-01-12 16:59                           ` Ric Wheeler
2010-01-12 17:00                             ` Michal Novotny
2010-01-14 13:46                               ` Michal Novotny
2010-01-12 12:47             ` Andreas Dilger
2010-01-12 13:04               ` Michal Novotny
2010-01-12 15:16           ` Eric Sandeen [this message]
2010-01-12 15:46             ` Michal Novotny
2010-01-12 20:01               ` Ric Wheeler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B4C9244.2050704@redhat.com \
    --to=sandeen@redhat.com \
    --cc=hch@infradead.org \
    --cc=linux-ext4@vger.kernel.org \
    --cc=minovotn@redhat.com \
    --cc=rwheeler@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).