From: Eric Sandeen <sandeen@redhat.com>
To: tytso@mit.edu
Cc: ext4 development <linux-ext4@vger.kernel.org>,
fmayhar@google.com, Giel de Nijs <giel@vectorwise.com>
Subject: Re: [PATCH V2] fix type of "offset" in ext4_io_end
Date: Fri, 05 Feb 2010 09:50:52 -0600 [thread overview]
Message-ID: <4B6C3E5C.4080907@redhat.com> (raw)
In-Reply-To: <20100205133751.GO25885@thunk.org>
tytso@mit.edu wrote:
> On Fri, Jan 29, 2010 at 02:28:23PM -0600, Eric Sandeen wrote:
>> The "offset" member in ext4_io_end holds bytes, not
>> blocks, so ext4_lblk_t is wrong - and too small (u32)
>>
>> This caused the testcase "Possible ext4 data corruption
>> with large files and async I/O" sent by Giel to fail when it
>> wrapped around to 0.
>>
>> Also fix up the type of arguments to
>> ext4_convert_unwritten_extents(), it gets ssize_t from
>> ext4_end_aio_dio_nolock() and ext4_ext_direct_IO()
>>
>> Reported-by: Giel de Nijs <giel@vectorwise.com>
>> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
>
> So I was going to submit this patch to Linus, but the last two times
> I've run xfsqa ("xfsqa -g quick" and "xfsqa -g auto"), test #126 has
> failed. If I run the test stand-alone, it passes. It's a bit of a
> head-scratcher. I'm currently backing out the patch and trying to do
> an xfsqa -g auto run to make sure this was something that had crept in
> before applying this patch, so this may very well not be this patch
> --- I certainly can't see anything wrong with it. But I thought I
> would give a heads up....
>
> - Ted
hrm 126 is a permissions test, I can't imagine it'd be related...
I see it fail on a sorta-stock .32 kernel like this:
--- 126.out 2009-08-05 20:19:40.380978986 -0500
+++ 126.out.bad 2010-02-05 09:01:13.088372667 -0600
@@ -5,7 +5,7 @@
w a 002 file owned by (99/99) as user/group(12/100) PASS
w a 020 file owned by (99/99) as user/group(200/99) PASS
w a 200 file owned by (99/99) as user/group(99/500) PASS
-r a 004 file owned by (99/99) as user/group(12/100) PASS
+r a 004 file owned by (99/99) as user/group(12/100) FAIL
r a 040 file owned by (99/99) as user/group(200/99) PASS
r a 400 file owned by (99/99) as user/group(99/500) PASS
r a 000 file owned by (99/99) as user/group(99/99) FAIL
What's your failure?
-Eric
next prev parent reply other threads:[~2010-02-05 15:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-29 18:24 [PATCH] fix type of "offset" in ext4_io_end Eric Sandeen
2010-01-29 20:21 ` Josef Bacik
2010-01-29 20:28 ` [PATCH V2] " Eric Sandeen
2010-01-29 20:32 ` Josef Bacik
2010-01-30 17:34 ` tytso
2010-01-30 18:33 ` Eric Sandeen
2010-02-05 13:37 ` tytso
2010-02-05 15:50 ` Eric Sandeen [this message]
2010-02-05 16:34 ` tytso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B6C3E5C.4080907@redhat.com \
--to=sandeen@redhat.com \
--cc=fmayhar@google.com \
--cc=giel@vectorwise.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).