From: Eric Sandeen <sandeen@redhat.com>
To: Andreas Dilger <adilger@sun.com>
Cc: tytso@mit.edu, ext4 development <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH] mke2fs: skip alignment questioning if -F specified
Date: Fri, 12 Mar 2010 09:17:19 -0600 [thread overview]
Message-ID: <4B9A5AFF.5020401@redhat.com> (raw)
In-Reply-To: <31D4615D-CB8C-48D7-934D-2CDAF327CF44@sun.com>
Andreas Dilger wrote:
> On 2010-03-11, at 19:48, tytso@mit.edu wrote:
>> On Mon, Mar 01, 2010 at 01:53:09PM -0600, Eric Sandeen wrote:
>>> RH bug 569021 - mke2fs insists on user interaction even if stdin is
>>> not a tty and -F is passed
>>>
>>> This is just a warning, -F should easily override it.
>
> Since this is just a warning, do we really need to have "-F" at all? I
> dislike requiring "-F" on common actions, because it means that it will
> commonly be used, but may accidentally override some unintended problem.
>
> We've lived without block device alignment until now, and it seems
> somewhat unpleasant that mke2fs may start failing (if -F is not given)
> for situations where it previously worked just fine.
Well, that's a good point, dropping the -F requirement is fine with me too,
I guess.
Ted do you want to just toss in:
- if (!force)
- proceed_question();
? I can send a patch but it may take longer for you to extract it from email ;)
-Eric
next prev parent reply other threads:[~2010-03-12 15:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-01 19:53 [PATCH] mke2fs: skip alignment questioning if -F specified Eric Sandeen
2010-03-12 2:48 ` tytso
2010-03-12 7:54 ` Andreas Dilger
2010-03-12 15:17 ` Eric Sandeen [this message]
2010-03-12 15:40 ` Theodore Tso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B9A5AFF.5020401@redhat.com \
--to=sandeen@redhat.com \
--cc=adilger@sun.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).