From: Eric Sandeen <sandeen@redhat.com>
To: tytso@mit.edu
Cc: linux-ext4@vger.kernel.org, Jan Kara <jack@suse.cz>
Subject: Re: [PATCH] ext4/super.c: Replace CONTIG_EXT{2,3}_FS by CONFIG_EXT{2,3}_FS
Date: Wed, 24 Mar 2010 11:21:59 -0500 [thread overview]
Message-ID: <4BAA3C27.2000505@redhat.com> (raw)
In-Reply-To: <20100324161201.GG2159@thunk.org>
On 03/24/2010 11:12 AM, tytso@mit.edu wrote:
> Thanks for catching this! This should fix it up...
>
> - Ted
>
> ext4: Fix build error when EXT4_USE_FOR_EXT23 disabled
>
> Fix a stupid type (CONTIG != CONFIG) and a stupid assumption that
> ext3_fs_type would always be defined.
>
> (The build failure could also happen when EXT4_USE_FOR_EXT23 is
> enabled and ext3 is built as a module.)
A little late, but right now we have this in Kconfig:
config EXT4_USE_FOR_EXT23
bool "Use ext4 for ext2/ext3 file systems"
depends on EXT4_FS
depends on EXT3_FS=n || EXT2_FS=n
do we really want "||" ?
so, if you turn off ext2, but leave ext3 on, it will ask you if you want
to use ext4 for ext3? That doesn't make sense to me.
Shouldn't it be:
- depends on EXT3_FS=n || EXT2_FS=n
+ depends on EXT3_FS=n && EXT2_FS=n
?
-Eric
next prev parent reply other threads:[~2010-03-24 16:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-24 11:05 [PATCH] ext4/super.c: Replace CONTIG_EXT{2,3}_FS by CONFIG_EXT{2,3}_FS Sedat Dilek
2010-03-24 16:12 ` tytso
2010-03-24 16:21 ` Eric Sandeen [this message]
2010-03-24 16:27 ` tytso
2010-03-24 16:30 ` Eric Sandeen
2010-03-24 16:57 ` Sedat Dilek
2010-03-25 1:59 ` tytso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BAA3C27.2000505@redhat.com \
--to=sandeen@redhat.com \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox