From: Eric Sandeen <sandeen@redhat.com>
To: ext4 development <linux-ext4@vger.kernel.org>
Cc: Jan Kara <jack@suse.cz>, Dmitry Monakhov <dmonakhov@openvz.org>
Subject: quota reservation fixes for -stable?
Date: Wed, 31 Mar 2010 10:36:12 -0500 [thread overview]
Message-ID: <4BB36BEC.2000207@redhat.com> (raw)
I think we should get the following commits to -stable:
0a5a9c725512461d19397490f3adf29931dca1f2 quota: Fix warning when a delayed write happens before quota is enabled
c469070aea5a0ada45a836937c776fd3083dae2b quota: manage reserved space when quota is not active [v2]
without these, we're just racking up the score on kerneloops:
http://www.kerneloops.org/searchweek.php?search=dquot_claim_space
(I think this is a #1 all-time high for a kerneloops count ;)
Pretty sure the 2 commits above can be backported w/o other
dependencies, but maybe Jan & Dmitry can confirm.
I dug into this a little; at least on stock .32 Fedora, it's really
only hitting on a few files, but seems to hit every time they're written:
/var/log/messages, audit.log, etc - things that likely were written
prior to quota being enabled. Perhaps this is a Fedora initscripts
bug...
But check this out, with a modified .32 kernel with the above 2 commints,
and a change that reports which inodes were modified:
VFS (sda12): inode(s) 1064
VFS (sda12): Writes happened before quota was turned on thus quota information is probably inconsistent. Please run quotacheck(8).
# find /etc -inum 1064
/etc/mtab
This sounds a little chicken-and-eggy to me!
Anyway, the above 2 commits should make things -significantly- better,
so w/o any objections, let's get them to -stable.
Thanks,
-Eric
next reply other threads:[~2010-03-31 15:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-31 15:36 Eric Sandeen [this message]
2010-04-01 8:23 ` quota reservation fixes for -stable? Jan Kara
2010-04-01 13:57 ` Eric Sandeen
2010-04-16 20:37 ` Eric Sandeen
2010-04-19 22:52 ` Jan Kara
2010-04-19 22:56 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BB36BEC.2000207@redhat.com \
--to=sandeen@redhat.com \
--cc=dmonakhov@openvz.org \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).