From: Eric Sandeen <sandeen@redhat.com>
To: Theodore Tso <tytso@MIT.EDU>
Cc: ext4 development <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH] ext4_freeze: don't return to userspace with a mutex held
Date: Sun, 04 Apr 2010 19:43:41 -0500 [thread overview]
Message-ID: <4BB9323D.7050206@redhat.com> (raw)
In-Reply-To: <A0351AEF-E91E-4CD8-A38E-DAE3EEEBB127@mit.edu>
Theodore Tso wrote:
> On Apr 4, 2010, at 5:23 PM, Eric Sandeen wrote:
>> Well, there is __generic_file_aio_write doing vfs_check_frozen, but
>> I thought there was more at the vfs level to stop things from
>> getting to the filesystem... *shrug* I see you put the patch in as
>> sent, it sounds right to me.
>
> Yeah, it looks safe but it would be nice to do some testing to make
> sure there's nothing we missed.
>
> I'm also vaguely worried whether the right thing will happen in
> no-journal mode, but it looks like it's better than what we had
> before (which clearly would have never worked in no journal mode), so
> I decided to let it pass.
I did go back up the callchain from where the old lock should have
caught it, so I think I've plugged the same holes that were protected
before.
> Testing the freeze functionality definitely needs to be done before
> we trust what happens in no journal mode, for sure.
Oh good point, hadn't even thought about nojournal mode & freeze.
Always nice to "accidentally" fix things ;)
-Eric
>
> -- Ted
>
> -- To unsubscribe from this list: send the line "unsubscribe
> linux-ext4" in the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2010-04-05 0:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-29 22:34 [PATCH] ext4_freeze: don't return to userspace with a mutex held Eric Sandeen
2010-04-04 20:52 ` tytso
2010-04-04 21:03 ` tytso
2010-04-04 21:23 ` Eric Sandeen
2010-04-04 21:56 ` Theodore Tso
2010-04-05 0:43 ` Eric Sandeen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BB9323D.7050206@redhat.com \
--to=sandeen@redhat.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@MIT.EDU \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).