From: Wang Sheng-Hui <crosslonelyover@gmail.com>
To: kernel-janitors <kernel-janitors@vger.kernel.org>,
linux-ext4 <linux-ext4@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: [PATCH] ext2: return -ENODATA for NULL i_file_acl in ext2_xattr_list
Date: Tue, 13 Jul 2010 22:55:21 +0800 [thread overview]
Message-ID: <4C3C7E59.8040905@gmail.com> (raw)
Hi,
In ext2_xattr_list, if (!EXT2_I(inode)->i_file_acl)
is true, we should return -ENODATA instead of 0.
Following patch is against 2.6.35-rc5. Please check
it.
Signed-off-by: Wang Sheng-Hui <crosslonelyover@gmail.com>
---
fs/ext2/xattr.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/fs/ext2/xattr.c b/fs/ext2/xattr.c
index 7c39157..5ecbbd8 100644
--- a/fs/ext2/xattr.c
+++ b/fs/ext2/xattr.c
@@ -263,7 +263,7 @@ ext2_xattr_list(struct dentry *dentry, char *buffer,
size_t buffer_size)
buffer, (long)buffer_size);
down_read(&EXT2_I(inode)->xattr_sem);
- error = 0;
+ error = -ENODATA;
if (!EXT2_I(inode)->i_file_acl)
goto cleanup;
ea_idebug(inode, "reading block %d", EXT2_I(inode)->i_file_acl);
--
1.7.1.1
--
Thanks and Regards,
shenghui
next reply other threads:[~2010-07-13 14:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-13 14:55 Wang Sheng-Hui [this message]
2010-07-13 18:36 ` [PATCH] ext2: return -ENODATA for NULL i_file_acl in ext2_xattr_list Andreas Dilger
2010-07-13 23:47 ` shenghui
-- strict thread matches above, loose matches on Subject: below --
2010-07-13 15:15 Wang Sheng-Hui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C3C7E59.8040905@gmail.com \
--to=crosslonelyover@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).