From: Eric Sandeen <sandeen@redhat.com>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs-oss <xfs@oss.sgi.com>, ext4 development <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH] xfstests 240: test non-aligned AIO hole-filling
Date: Thu, 22 Jul 2010 22:37:20 -0500 [thread overview]
Message-ID: <4C490E70.3030902@redhat.com> (raw)
In-Reply-To: <4C490D4D.603@redhat.com>
Eric Sandeen wrote:
> Dave Chinner wrote:
...
>> looks good - it needs to remove the $TEST_DIR/aiodio_sparse file
>> before the test starts, though, so that repeated tests fail
>> correctly. Otherwise:
>>
>>
> hm, but:
>
> +rm -f "$TEST_DIR/aiodio_sparse*"
> +
> +# 2 threads, 4k writes, 16k filesize, stride throug file by 4k, start at 512 offset
> +$here/src/aio-dio-regress/aiodio_sparse2 -i 2 -w 4k -s 16k -n 4k -o 512 "$TEST_DIR/aiodio_sparse"
>
> It does remove it ... no?
hm, no, what are those quotes doing there...
Ok, will fix up thanks.
-Eric
next prev parent reply other threads:[~2010-07-23 3:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-22 19:05 [PATCH] xfstests 240: test non-aligned AIO hole-filling Eric Sandeen
2010-07-23 2:49 ` Dave Chinner
2010-07-23 3:32 ` Eric Sandeen
2010-07-23 3:37 ` Eric Sandeen [this message]
2010-07-23 3:58 ` Dave Chinner
2010-07-23 10:12 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C490E70.3030902@redhat.com \
--to=sandeen@redhat.com \
--cc=david@fromorbit.com \
--cc=linux-ext4@vger.kernel.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).