* [PATCH] mke2fs: make "invalid blocks count" error more clear
@ 2010-08-12 18:40 Eric Sandeen
2010-09-20 13:26 ` Ted Ts'o
0 siblings, 1 reply; 2+ messages in thread
From: Eric Sandeen @ 2010-08-12 18:40 UTC (permalink / raw)
To: ext4 development
Mistakes on the commandline can lead to odd error messages:
# mke2fs -t ext4 -E stride=128 stripe-width=512 /dev/sda1
mke2fs: invalid blocks count - /dev/sda1
Making it a bit more explicit is more obvious:
mke2fs: invalid blocks count '/dev/sda1' on device 'stripe-width=512'
(hint, the mistake was no comma separation for -E)
Reported-by: Adam Huffman <bloch@verdurin.com>
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---
diff --git a/misc/mke2fs.c b/misc/mke2fs.c
index add7c0c..a34c1ba 100644
--- a/misc/mke2fs.c
+++ b/misc/mke2fs.c
@@ -1415,8 +1415,9 @@ static void PRS(int argc, char *argv[])
fs_blocks_count = parse_num_blocks2(argv[optind++],
fs_param.s_log_block_size);
if (!fs_blocks_count) {
- com_err(program_name, 0, _("invalid blocks count - %s"),
- argv[optind - 1]);
+ com_err(program_name, 0,
+ _("invalid blocks count '%s' on device '%s'"),
+ argv[optind - 1], device_name);
exit(1);
}
}
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] mke2fs: make "invalid blocks count" error more clear
2010-08-12 18:40 [PATCH] mke2fs: make "invalid blocks count" error more clear Eric Sandeen
@ 2010-09-20 13:26 ` Ted Ts'o
0 siblings, 0 replies; 2+ messages in thread
From: Ted Ts'o @ 2010-09-20 13:26 UTC (permalink / raw)
To: Eric Sandeen; +Cc: ext4 development
On Thu, Aug 12, 2010 at 02:40:44PM -0400, Eric Sandeen wrote:
> Mistakes on the commandline can lead to odd error messages:
>
> # mke2fs -t ext4 -E stride=128 stripe-width=512 /dev/sda1
> mke2fs: invalid blocks count - /dev/sda1
>
> Making it a bit more explicit is more obvious:
>
> mke2fs: invalid blocks count '/dev/sda1' on device 'stripe-width=512'
>
> (hint, the mistake was no comma separation for -E)
>
> Reported-by: Adam Huffman <bloch@verdurin.com>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Applied to the e2fsprogs maint branch, thanks!!
- Ted
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-09-20 13:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-08-12 18:40 [PATCH] mke2fs: make "invalid blocks count" error more clear Eric Sandeen
2010-09-20 13:26 ` Ted Ts'o
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).