From: Eric Sandeen <sandeen@redhat.com>
To: ext4 development <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH 0/2] ext4: a couple writeback path fixes
Date: Fri, 03 Sep 2010 17:11:30 -0500 [thread overview]
Message-ID: <4C817292.9070000@redhat.com> (raw)
In-Reply-To: <4C7D0A00.40601@redhat.com>
Eric Sandeen wrote:
> I've found a couple small problems in the ext4_da_writepages path;
>
> 1) ext4_num_dirty_pages() can continue looping after max_pages is reached
> - this leads to wasted cpu cycles during writeback
>
> 2) bumping nr_to_write can wrap if we started with LONG_MAX
> - Not sure of all ramifications, but nr_to_write = -8 can't be good
>
> -Eric
sigh just nak this whole thing for now, too many errors.
Will resubmit after more careful reading, patching, and testing.
Sorry for the noise.
-Eric
prev parent reply other threads:[~2010-09-03 22:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-31 13:56 [PATCH 0/2] ext4: a couple writeback path fixes Eric Sandeen
2010-08-31 13:59 ` PATCH 1/2] ext4: stop looping in ext4_num_dirty_pages when max_pages reached Eric Sandeen
2010-08-31 14:04 ` [PATCH 2/2] ext4: don't bump nr_to_write if LONG_MAX Eric Sandeen
2010-08-31 14:20 ` [PATCH 2/2 V2] " Eric Sandeen
2010-09-03 21:37 ` Eric Sandeen
2010-09-03 22:11 ` Eric Sandeen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C817292.9070000@redhat.com \
--to=sandeen@redhat.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).