From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Sandeen Subject: Re: [PATCH 0/2] ext4: a couple writeback path fixes Date: Fri, 03 Sep 2010 17:11:30 -0500 Message-ID: <4C817292.9070000@redhat.com> References: <4C7D0A00.40601@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit To: ext4 development Return-path: Received: from mx1.redhat.com ([209.132.183.28]:52435 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753256Ab0ICWLd (ORCPT ); Fri, 3 Sep 2010 18:11:33 -0400 Received: from int-mx03.intmail.prod.int.phx2.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o83MBXIx032358 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 3 Sep 2010 18:11:33 -0400 Received: from liberator.sandeen.net (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx03.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o83MBUgC014989 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Fri, 3 Sep 2010 18:11:32 -0400 In-Reply-To: <4C7D0A00.40601@redhat.com> Sender: linux-ext4-owner@vger.kernel.org List-ID: Eric Sandeen wrote: > I've found a couple small problems in the ext4_da_writepages path; > > 1) ext4_num_dirty_pages() can continue looping after max_pages is reached > - this leads to wasted cpu cycles during writeback > > 2) bumping nr_to_write can wrap if we started with LONG_MAX > - Not sure of all ramifications, but nr_to_write = -8 can't be good > > -Eric sigh just nak this whole thing for now, too many errors. Will resubmit after more careful reading, patching, and testing. Sorry for the noise. -Eric