From: Eric Sandeen <sandeen@redhat.com>
To: Andreas Dilger <adilger.kernel@dilger.ca>
Cc: "Ted Ts'o" <tytso@mit.edu>,
Ext4 Developers List <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH] annotate superblock field offsets
Date: Mon, 29 Nov 2010 17:46:36 -0600 [thread overview]
Message-ID: <4CF43B5C.2020909@redhat.com> (raw)
In-Reply-To: <7258D44F-8334-4604-90EE-019F1B33B1FC@dilger.ca>
On 11/29/10 5:45 PM, Andreas Dilger wrote:
> The s_mount_options field has the unfortunate distinction of being the first field beyond 0x200 in the superblock (i.e. second sector of 1kB superblock area).
>
> Annotate the superblock fields with offsets so that it is easier to see
> these boundaries, and decode the superblock in the future.
>
> Cheers, Andreas
>
thank you, I had just about done this in anger as well ;)
-Eric
next prev parent reply other threads:[~2010-11-29 23:46 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-25 21:23 [Bug 23772] New: oops after mounting ext4 fs in 2.6.36.1 (failed to parse options in superblock) bugzilla-daemon
2010-11-25 21:27 ` [Bug 23772] " bugzilla-daemon
2010-11-25 21:31 ` bugzilla-daemon
2010-11-25 21:32 ` bugzilla-daemon
2010-11-26 2:57 ` bugzilla-daemon
2010-11-26 14:24 ` bugzilla-daemon
2010-11-26 14:27 ` bugzilla-daemon
2010-11-26 14:40 ` bugzilla-daemon
2010-11-26 14:45 ` bugzilla-daemon
2010-11-26 14:46 ` bugzilla-daemon
2010-11-26 20:45 ` bugzilla-daemon
2010-11-26 22:13 ` bugzilla-daemon
2010-11-29 19:34 ` bugzilla-daemon
2010-11-29 19:36 ` bugzilla-daemon
2010-11-29 21:55 ` bugzilla-daemon
2010-11-29 23:45 ` [PATCH] annotate superblock field offsets Andreas Dilger
2010-11-29 23:46 ` Eric Sandeen [this message]
2010-11-30 16:51 ` [Bug 23772] oops after mounting ext4 fs in 2.6.36.1 (failed to parse options in superblock) bugzilla-daemon
2010-11-30 17:50 ` bugzilla-daemon
2010-11-30 18:07 ` bugzilla-daemon
2010-11-30 20:54 ` bugzilla-daemon
2010-11-30 21:16 ` bugzilla-daemon
2010-12-01 14:58 ` bugzilla-daemon
2012-08-14 13:33 ` bugzilla-daemon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CF43B5C.2020909@redhat.com \
--to=sandeen@redhat.com \
--cc=adilger.kernel@dilger.ca \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).