* [PATCH] ext4: fix typo in ext4_find_entry()
@ 2010-12-08 16:33 Aaro Koskinen
2010-12-08 17:53 ` Eric Sandeen
0 siblings, 1 reply; 3+ messages in thread
From: Aaro Koskinen @ 2010-12-08 16:33 UTC (permalink / raw)
To: tytso, linux-ext4, linux-kernel; +Cc: ext-phil.2.carmody
There should be a check for NUL character instead of '0'.
Reported-by: Phil Carmody <ext-phil.2.carmody@nokia.com>
Signed-off-by: Aaro Koskinen <aaro.koskinen@nokia.com>
---
fs/ext4/namei.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/fs/ext4/namei.c b/fs/ext4/namei.c
index 92203b8..dc40e75 100644
--- a/fs/ext4/namei.c
+++ b/fs/ext4/namei.c
@@ -872,7 +872,7 @@ static struct buffer_head * ext4_find_entry (struct inode *dir,
if (namelen > EXT4_NAME_LEN)
return NULL;
if ((namelen <= 2) && (name[0] == '.') &&
- (name[1] == '.' || name[1] == '0')) {
+ (name[1] == '.' || name[1] == '\0')) {
/*
* "." or ".." will only be in the first block
* NFS may look up ".."; "." should be handled by the VFS
--
1.5.6.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ext4: fix typo in ext4_find_entry()
2010-12-08 16:33 [PATCH] ext4: fix typo in ext4_find_entry() Aaro Koskinen
@ 2010-12-08 17:53 ` Eric Sandeen
2010-12-16 13:41 ` Roman Borisov
0 siblings, 1 reply; 3+ messages in thread
From: Eric Sandeen @ 2010-12-08 17:53 UTC (permalink / raw)
To: Aaro Koskinen; +Cc: tytso, linux-ext4, linux-kernel, ext-phil.2.carmody
On 12/08/2010 10:33 AM, Aaro Koskinen wrote:
> There should be a check for NUL character instead of '0'.
>
> Reported-by: Phil Carmody <ext-phil.2.carmody@nokia.com>
> Signed-off-by: Aaro Koskinen <aaro.koskinen@nokia.com>
> ---
> fs/ext4/namei.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/fs/ext4/namei.c b/fs/ext4/namei.c
> index 92203b8..dc40e75 100644
> --- a/fs/ext4/namei.c
> +++ b/fs/ext4/namei.c
> @@ -872,7 +872,7 @@ static struct buffer_head * ext4_find_entry (struct inode *dir,
> if (namelen > EXT4_NAME_LEN)
> return NULL;
> if ((namelen <= 2) && (name[0] == '.') &&
> - (name[1] == '.' || name[1] == '0')) {
> + (name[1] == '.' || name[1] == '\0')) {
> /*
> * "." or ".." will only be in the first block
> * NFS may look up ".."; "." should be handled by the VFS
Yep, as it was reviewed on the list when originally sent, oops! ;)
-Eric
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ext4: fix typo in ext4_find_entry()
2010-12-08 17:53 ` Eric Sandeen
@ 2010-12-16 13:41 ` Roman Borisov
0 siblings, 0 replies; 3+ messages in thread
From: Roman Borisov @ 2010-12-16 13:41 UTC (permalink / raw)
To: ext Eric Sandeen, jack
Cc: Aaro Koskinen, tytso, linux-ext4, linux-kernel,
ext-phil.2.carmody
On 12/08/2010 08:53 PM, ext Eric Sandeen wrote:
> On 12/08/2010 10:33 AM, Aaro Koskinen wrote:
>> There should be a check for NUL character instead of '0'.
>>
>> Reported-by: Phil Carmody<ext-phil.2.carmody@nokia.com>
>> Signed-off-by: Aaro Koskinen<aaro.koskinen@nokia.com>
>> ---
>> fs/ext4/namei.c | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/fs/ext4/namei.c b/fs/ext4/namei.c
>> index 92203b8..dc40e75 100644
>> --- a/fs/ext4/namei.c
>> +++ b/fs/ext4/namei.c
>> @@ -872,7 +872,7 @@ static struct buffer_head * ext4_find_entry (struct inode *dir,
>> if (namelen> EXT4_NAME_LEN)
>> return NULL;
>> if ((namelen<= 2)&& (name[0] == '.')&&
>> - (name[1] == '.' || name[1] == '0')) {
>> + (name[1] == '.' || name[1] == '\0')) {
>> /*
>> * "." or ".." will only be in the first block
>> * NFS may look up ".."; "." should be handled by the VFS
>
> Yep, as it was reviewed on the list when originally sent, oops! ;)
>
> -Eric
Hi,
the same fix should be done for ext3 patch which is planned to be in
mainline: http://www.spinics.net/lists/linux-ext4/msg21215.html
Roman
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-12-16 13:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-12-08 16:33 [PATCH] ext4: fix typo in ext4_find_entry() Aaro Koskinen
2010-12-08 17:53 ` Eric Sandeen
2010-12-16 13:41 ` Roman Borisov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).