linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Eric Sandeen <sandeen@redhat.com>
To: "Ted Ts'o" <tytso@mit.edu>
Cc: Andreas Dilger <adilger@dilger.ca>,
	Kazuya Mio <k-mio@sx.jp.nec.com>,
	ext4 <linux-ext4@vger.kernel.org>
Subject: Re: ext4: Fix 32bit overflow in ext4_ext_find_goal()
Date: Mon, 03 Jan 2011 11:25:58 -0600	[thread overview]
Message-ID: <4D2206A6.1080505@redhat.com> (raw)
In-Reply-To: <20110103041157.GE11955@thunk.org>

On 01/02/2011 10:11 PM, Ted Ts'o wrote:
> On Sun, Jan 02, 2011 at 08:35:39PM -0700, Andreas Dilger wrote:
>> It was written that way because HPC applications writing to a shared
>> file normally write to an offset of task_num * task_data_size so
>> they do not overlap, and end up with a dense file. Similarly,
>> bittorrent and parallel FTP clients will write dense files after
>> seeking randomly around the file, and database files often end up
>> dense as well.
>>
>> I'd rather fix the relatively few applications that expect
>> permanently sparse files to use fadvise() to notify the kernel of
>> this.
> 
> Agreed, and I'm not sure there are enough applications that expect
> permanently sparse files that's worth adding a new fadvise().  But if
> we do add a new fadvise(), the default should clearly be the current
> behavior.
> 
> If someone knows of use cases where permanently sparse files are
> common, please let us know!

RPM database files stay sparse (Berkeley DB)

$ pwd
/var/lib/rpm
$ ls -lh Basenames; du -h Basenames
-rw-r--r-- 1 rpm rpm 11M Dec  8 12:55 Basenames
9.1M	Basenames

etc.

-Eric

  parent reply	other threads:[~2011-01-03 17:26 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-13  5:37 [PATCH] ext4: Fix 32bit overflow in ext4_ext_find_goal() Kazuya Mio
2011-01-02 21:40 ` Ted Ts'o
2011-01-03  3:35   ` Andreas Dilger
2011-01-03  4:11     ` Ted Ts'o
2011-01-03  7:02       ` Amir Goldstein
2011-01-03 17:25       ` Eric Sandeen [this message]
2011-01-03 15:36   ` Rogier Wolff

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D2206A6.1080505@redhat.com \
    --to=sandeen@redhat.com \
    --cc=adilger@dilger.ca \
    --cc=k-mio@sx.jp.nec.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).