From: Eric Sandeen <sandeen@redhat.com>
To: Lukas Czerner <lczerner@redhat.com>
Cc: linux-ext4@vger.kernel.org, tytso@mit.edu
Subject: Re: [PATCH] ext4: Unregister features interface on module unload
Date: Tue, 18 Jan 2011 14:10:12 -0600 [thread overview]
Message-ID: <4D35F3A4.1070402@redhat.com> (raw)
In-Reply-To: <4D35ECD1.3070502@redhat.com>
On 01/18/2011 01:41 PM, Eric Sandeen wrote:
>
>
> On 01/17/2011 12:09 PM, Eric Sandeen wrote:
>
>> On 01/17/2011 09:00 AM, Lukas Czerner wrote:
>>> Ext4 features interface was not properly unregistered which led to
>>> problems while unloading/reloading ext4 module. This commit fixes that by
>>> adding proper kobject unregistration code into ext4_exit_fs() as well as
>>> fail-path of ext4_init_fs()
>>>
>>> Signed-off-by: Lukas Czerner <lczerner@redhat.com>
>>> Reported-by: Eric Sandeen <sandeen@redhat.com>
>> Works for me!
>>
> I may have spoken too soon. After a few insmod/mount/io/umount/rmmod loops I got:
>
> [ 95.625277] general protection fault: 0000 [#1] SMP
>
Sorry, I think this is Yet Another Problem and your patch is fine;
reverting the whole features advert commit and doing the same test
yields the same failure.
-Eric
next prev parent reply other threads:[~2011-01-18 20:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-17 15:00 [PATCH] ext4: Unregister features interface on module unload Lukas Czerner
2011-01-17 18:09 ` Eric Sandeen
2011-01-17 18:21 ` Lukas Czerner
2011-01-17 18:40 ` Eric Sandeen
2011-01-18 19:41 ` Eric Sandeen
2011-01-18 20:10 ` Eric Sandeen [this message]
2011-01-24 17:49 ` Lukas Czerner
2011-02-03 5:53 ` Ted Ts'o
2011-02-03 5:55 ` [PATCH] ext4: fix up ext4 error handling Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D35F3A4.1070402@redhat.com \
--to=sandeen@redhat.com \
--cc=lczerner@redhat.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).