From: Eric Sandeen <sandeen@redhat.com>
To: Theodore Tso <tytso@mit.edu>
Cc: Curt Wohlgemuth <curtw@google.com>,
ext4 development <linux-ext4@vger.kernel.org>
Subject: Re: ext4: Fix clear_buffer_dirty() call for mblk_io_submit writepages path
Date: Wed, 02 Feb 2011 10:58:46 -0600 [thread overview]
Message-ID: <4D498D46.9060801@redhat.com> (raw)
In-Reply-To: <3DDF4CC0-B456-425D-A132-A082B27379F2@mit.edu>
On 2/1/11 1:37 AM, Theodore Tso wrote:
>
> On Jan 31, 2011, at 11:21 PM, Eric Sandeen wrote:
>
>> On 1/31/11 6:15 PM, Curt Wohlgemuth wrote:
>>> Sorry: I forgot to mention that I tested this on 2.6.37 under KVM
>>> with the postgresql script specified by Ted in
>>> 1449032be17abb69116dbc393f67ceb8bd034f92 -- without this commit, and
>>> hence by default using the multiblock writepages submittal code.
>>>
>>> Without the patch, I'd hit the corruption problem about 50-70% of the
>>> time. With the patch, I executed the script > 100 times with no
>>> corruption seen.
>>
>> Can you resubmit with a changelog that indicates it's actually a corruption
>> fix? Maybe even in the summary. That is important information to have
>> for the commit...
>
> Agreed, although I'd also point out that the corruption fix was for code that
> was disabled by default before 2.6.37 shipped, precisely because of the
> reported corruption bug, and that this code should make it safe to use
> the mblk_io_submit mount option, which will become the default in
> 2.6.39.
Right, but a corruption fix should never be committed w/o clear notice.
Speaking as one who does a fair bit of git archaeology, it drives me nuts
to have commits which look innocuous and are in fact momentous.
> Normally I add such clarifications in the commit description (I'm used to
> editing descriptions to correct English and to make things clearer, so for
> me this is no big deal), but if you want resubmit with an updated description
> and save me some work, I won't complain. :-)
Ok, just trying to coach a bit ;)
-Eric
> -- Ted
>
prev parent reply other threads:[~2011-02-02 16:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-31 20:44 ext4: Fix clear_buffer_dirty() call for mblk_io_submit writepages path Curt Wohlgemuth
2011-02-01 0:15 ` Curt Wohlgemuth
2011-02-01 4:21 ` Eric Sandeen
2011-02-01 7:37 ` Theodore Tso
2011-02-02 16:58 ` Eric Sandeen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D498D46.9060801@redhat.com \
--to=sandeen@redhat.com \
--cc=curtw@google.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).