* [PATCH 4/5] mballoc: change comments to ac_g_ex
@ 2011-02-06 4:54 Coly Li
2011-02-24 19:08 ` Ted Ts'o
0 siblings, 1 reply; 2+ messages in thread
From: Coly Li @ 2011-02-06 4:54 UTC (permalink / raw)
To: linux-ext4; +Cc: Alex Tomas, Theodore Tso
Current comments to ac_g_ex, the member of struct
ext4_allocation_context is,
/* goal request (after normalization) */
This is a little bit confused. In order to make it easier to be
understood, this patch modify the comments as,
/* goal request (normalized ac_o_ex) */
which means ac_g_ex is a normalized value of ac_o_ex.
Signed-off-by: Coly Li <bosong.ly@taobao.com>
Cc: Alex Tomas <alex@clusterfs.com>
Cc: Theodore Tso <tytso@google.com>
---
fs/ext4/mballoc.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/fs/ext4/mballoc.h b/fs/ext4/mballoc.h
index b619322..22bd4d7 100644
--- a/fs/ext4/mballoc.h
+++ b/fs/ext4/mballoc.h
@@ -169,7 +169,7 @@ struct ext4_allocation_context {
/* original request */
struct ext4_free_extent ac_o_ex;
- /* goal request (after normalization) */
+ /* goal request (normalized ac_o_ex) */
struct ext4_free_extent ac_g_ex;
/* the best found extent */
--
1.7.3.4
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH 4/5] mballoc: change comments to ac_g_ex
2011-02-06 4:54 [PATCH 4/5] mballoc: change comments to ac_g_ex Coly Li
@ 2011-02-24 19:08 ` Ted Ts'o
0 siblings, 0 replies; 2+ messages in thread
From: Ted Ts'o @ 2011-02-24 19:08 UTC (permalink / raw)
To: Coly Li; +Cc: linux-ext4, Alex Tomas, Theodore Tso
On Sun, Feb 06, 2011 at 12:54:08PM +0800, Coly Li wrote:
> Current comments to ac_g_ex, the member of struct
> ext4_allocation_context is,
> /* goal request (after normalization) */
> This is a little bit confused. In order to make it easier to be
> understood, this patch modify the comments as,
> /* goal request (normalized ac_o_ex) */
> which means ac_g_ex is a normalized value of ac_o_ex.
>
> Signed-off-by: Coly Li <bosong.ly@taobao.com>
> Cc: Alex Tomas <alex@clusterfs.com>
> Cc: Theodore Tso <tytso@google.com>
Added to the ext4 patch queue, thanks.
I used a much simpler patch comment:
ext4: clarify description of ac_g_ex in struct ext4_allocation_context
Signed-off-by: Coly Li <bosong.ly@taobao.com>
Cc: Alex Tomas <alex@clusterfs.com>
Cc: Theodore Tso <tytso@google.com>
- Ted
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-02-24 19:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-02-06 4:54 [PATCH 4/5] mballoc: change comments to ac_g_ex Coly Li
2011-02-24 19:08 ` Ted Ts'o
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).