From: Eric Sandeen <sandeen@redhat.com>
To: "Ted Ts'o" <tytso@mit.edu>
Cc: Steven Liu <lingjiujianke@gmail.com>,
linux-ext4@vger.kernel.org, liuqi <liuqi@thunderst.com>
Subject: Re: [PATCH] code cleanup on include/linux/fs.h
Date: Thu, 17 Feb 2011 11:25:17 -0600 [thread overview]
Message-ID: <4D5D59FD.3050200@redhat.com> (raw)
In-Reply-To: <20110217161445.GI26780@thunk.org>
On 2/17/11 10:14 AM, Ted Ts'o wrote:
> On Thu, Feb 17, 2011 at 05:38:43PM +0800, Steven Liu wrote:
>> Hi Ted,
>>
>>
>> Can this patch be fixed.
>>
>> Cleanup the unsed code on include/linux/fs.h.
>> All filesystem using mount_bdev and mount_nodev
>> to replace get_sb_bdev and get_sb_nodev.
>> So rmmove the unused code.
>
> Um, why are you sending this to the linux-ext4 list?
To be clear, sending this to linux-fsdevel and linux-kernel would probably
be more appropriate. With the changes Ted suggested.
-Eric
> And if you really want to get rid of get_sb_bdev and get_sb_nodev, you
> should send a single patch which removes it from all files in the
> Linux source tree, as well as updating references to these functions
> in the Documentation/filesystems/porting file.
>
> - Ted
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2011-02-17 17:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-17 9:38 [PATCH] code cleanup on include/linux/fs.h Steven Liu
2011-02-17 16:14 ` Ted Ts'o
2011-02-17 17:25 ` Eric Sandeen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D5D59FD.3050200@redhat.com \
--to=sandeen@redhat.com \
--cc=lingjiujianke@gmail.com \
--cc=linux-ext4@vger.kernel.org \
--cc=liuqi@thunderst.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).