From: Tao Ma <tm@tao.ma>
To: Christoph Hellwig <hch@infradead.org>, linux-ext4@vger.kernel.org
Subject: Re: [PATCH v2] ext4: Fix a BUG in mb_mark_used during trim.
Date: Thu, 03 Mar 2011 23:33:35 +0800 [thread overview]
Message-ID: <4D6FB4CF.4040202@tao.ma> (raw)
In-Reply-To: <20110303141109.GB16191@infradead.org>
Hi Christoph,
On 03/03/2011 10:11 PM, Christoph Hellwig wrote:
> On Thu, Mar 03, 2011 at 09:59:34PM +0800, Tao Ma wrote:
>> From: Tao Ma<boyu.mt@taobao.com>
>>
>> In a bs=4096 volume, if we call FITRIM with the following parameter as
>> fstrim_range(start = 102400, len = 134144000, minlen = 10240),
> Can you add a xfstests regression test for this particular invocation?
> We already have Lukas' fstrim.c tester in the tree, so it could be a
> simple wrapper around it.
Actually these numbers are related to the block size of a ext4 volume.
To be more specific, with the above number, we have
first_block + block_len > EXT4_BLOCKS_PER_GROUP while
block_len < EXT4_BLOCKS_PER_GROUP.
So do you think it is generic enough for a test case in xfstests since
now this
tool kit is also used to test xfs and btrfs?
Regards,
Tao
next prev parent reply other threads:[~2011-03-03 15:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-03 9:33 [PATCH] ext4: Fix a BUG in mb_mark_used during trim Tao Ma
2011-03-03 10:01 ` Lukas Czerner
2011-03-03 10:13 ` Tao Ma
2011-03-03 10:17 ` Lukas Czerner
2011-03-03 13:59 ` [PATCH v2] " Tao Ma
2011-03-03 14:20 ` Lukas Czerner
[not found] ` <20110303141109.GB16191@infradead.org>
2011-03-03 15:33 ` Tao Ma [this message]
2011-03-03 15:38 ` Christoph Hellwig
2011-03-16 15:20 ` [PATCH v2] ext4: Fix a kernel panic " Tao Ma
2011-03-23 19:47 ` [PATCH v2] ext4: Fix a BUG " Ted Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D6FB4CF.4040202@tao.ma \
--to=tm@tao.ma \
--cc=hch@infradead.org \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).