* [PATCH] e2fsprogs: create com_err.h symlink in includedir
@ 2011-02-16 18:01 Eric Sandeen
2011-02-20 23:10 ` Ted Ts'o
0 siblings, 1 reply; 7+ messages in thread
From: Eric Sandeen @ 2011-02-16 18:01 UTC (permalink / raw)
To: ext4 development; +Cc: mitchb
After debian bug #192277, debian/rules started making a symlink
to com_err.h in /usr/include. Now I have Fedora bug #550889
for the same issue, and perhaps it's time to make this symlink
by default, rather than fixing it up in packaging steps?
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---
diff --git a/debian/rules b/debian/rules
index 9fe59e6..41fca24 100755
--- a/debian/rules
+++ b/debian/rules
@@ -326,8 +326,6 @@ install-std: build
${INSTALL_PROGRAM} $(E2FSCK_STATIC) ${tmpdir}/sbin
cp ${mandir}/man8/e2fsck.8 ${mandir}/man8/e2fsck.static.8
- ln -s et/com_err.h ${tmpdir}/usr/include
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] e2fsprogs: create com_err.h symlink in includedir
2011-02-16 18:01 [PATCH] e2fsprogs: create com_err.h symlink in includedir Eric Sandeen
@ 2011-02-20 23:10 ` Ted Ts'o
2011-03-19 15:03 ` Eric Sandeen
0 siblings, 1 reply; 7+ messages in thread
From: Ted Ts'o @ 2011-02-20 23:10 UTC (permalink / raw)
To: Eric Sandeen; +Cc: ext4 development, mitchb
On Wed, Feb 16, 2011 at 12:01:39PM -0600, Eric Sandeen wrote:
> After debian bug #192277, debian/rules started making a symlink
> to com_err.h in /usr/include. Now I have Fedora bug #550889
> for the same issue, and perhaps it's time to make this symlink
> by default, rather than fixing it up in packaging steps?
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Pulled into the e2fsprogs tree, with the following change:
[ Changed by tytso to remove the explicit -s option; this will
default to creating a hard link by default, which slightly faster.
If people want to use symlinks for all links during the install
process, they can use configure option --enable-symlink-install.
The reason for this change is that some file systems, like AFS,
don't support symlinks, and AFS users complain when they can't build
or install into AFS. So I don't want to use symlinks
unconditionally without a way of switching things back and forth,
and it's easier if we just make all links made during the install
process to be hard links or sym links. ]
- Ted
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] e2fsprogs: create com_err.h symlink in includedir
2011-02-20 23:10 ` Ted Ts'o
@ 2011-03-19 15:03 ` Eric Sandeen
2011-06-16 20:39 ` Eric Sandeen
0 siblings, 1 reply; 7+ messages in thread
From: Eric Sandeen @ 2011-03-19 15:03 UTC (permalink / raw)
To: Ted Ts'o; +Cc: ext4 development, mitchb, Bruce Cassidy
On 2/20/11 5:10 PM, Ted Ts'o wrote:
> On Wed, Feb 16, 2011 at 12:01:39PM -0600, Eric Sandeen wrote:
>> After debian bug #192277, debian/rules started making a symlink
>> to com_err.h in /usr/include. Now I have Fedora bug #550889
>> for the same issue, and perhaps it's time to make this symlink
>> by default, rather than fixing it up in packaging steps?
>>
>> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
>
> Pulled into the e2fsprogs tree, with the following change:
>
> [ Changed by tytso to remove the explicit -s option; this will
> default to creating a hard link by default, which slightly faster.
> If people want to use symlinks for all links during the install
> process, they can use configure option --enable-symlink-install.
> The reason for this change is that some file systems, like AFS,
> don't support symlinks, and AFS users complain when they can't build
> or install into AFS. So I don't want to use symlinks
> unconditionally without a way of switching things back and forth,
> and it's easier if we just make all links made during the install
> process to be hard links or sym links. ]
>
>
> - Ted
Hm, now in a "make rpm" build which has source in one place and rpm build
area in another:
/bin/ln: creating hard link `/home/sandeen/rpmbuild/BUILDROOT/e2fsprogs-1.41.14-0.x86_64/usr/include/com_err.h' => `/usr/include/et/com_err.h': Invalid cross-device link
so I'm not quite sure how to work around this.
Maybe in the end it does have to be packaging-specific, with the
link created by the distro pkg scripts...?
-Eric
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] e2fsprogs: create com_err.h symlink in includedir
2011-03-19 15:03 ` Eric Sandeen
@ 2011-06-16 20:39 ` Eric Sandeen
2011-06-17 2:31 ` Ted Ts'o
0 siblings, 1 reply; 7+ messages in thread
From: Eric Sandeen @ 2011-06-16 20:39 UTC (permalink / raw)
To: Ted Ts'o; +Cc: ext4 development, mitchb, Bruce Cassidy
On 3/19/11 10:03 AM, Eric Sandeen wrote:
> On 2/20/11 5:10 PM, Ted Ts'o wrote:
>> On Wed, Feb 16, 2011 at 12:01:39PM -0600, Eric Sandeen wrote:
>>> After debian bug #192277, debian/rules started making a symlink
>>> to com_err.h in /usr/include. Now I have Fedora bug #550889
>>> for the same issue, and perhaps it's time to make this symlink
>>> by default, rather than fixing it up in packaging steps?
>>>
>>> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
>>
>> Pulled into the e2fsprogs tree, with the following change:
>>
>> [ Changed by tytso to remove the explicit -s option; this will
>> default to creating a hard link by default, which slightly faster.
>> If people want to use symlinks for all links during the install
>> process, they can use configure option --enable-symlink-install.
>> The reason for this change is that some file systems, like AFS,
>> don't support symlinks, and AFS users complain when they can't build
>> or install into AFS. So I don't want to use symlinks
>> unconditionally without a way of switching things back and forth,
>> and it's easier if we just make all links made during the install
>> process to be hard links or sym links. ]
>>
>>
>> - Ted
>
> Hm, now in a "make rpm" build which has source in one place and rpm build
> area in another:
>
> /bin/ln: creating hard link `/home/sandeen/rpmbuild/BUILDROOT/e2fsprogs-1.41.14-0.x86_64/usr/include/com_err.h' => `/usr/include/et/com_err.h': Invalid cross-device link
>
> so I'm not quite sure how to work around this.
>
> Maybe in the end it does have to be packaging-specific, with the
> link created by the distro pkg scripts...?
Ted, your change broke any builds span 2 different filesystems.
Now what?
-Eric
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] e2fsprogs: create com_err.h symlink in includedir
2011-06-16 20:39 ` Eric Sandeen
@ 2011-06-17 2:31 ` Ted Ts'o
2011-06-17 3:54 ` Andreas Dilger
2011-06-17 14:27 ` Eric Sandeen
0 siblings, 2 replies; 7+ messages in thread
From: Ted Ts'o @ 2011-06-17 2:31 UTC (permalink / raw)
To: Eric Sandeen; +Cc: ext4 development, mitchb, Bruce Cassidy
On Thu, Jun 16, 2011 at 03:39:07PM -0500, Eric Sandeen wrote:
> > Hm, now in a "make rpm" build which has source in one place and rpm build
> > area in another:
> >
> > /bin/ln: creating hard link `/home/sandeen/rpmbuild/BUILDROOT/e2fsprogs-1.41.14-0.x86_64/usr/include/com_err.h' => `/usr/include/et/com_err.h': Invalid cross-device link
> >
> > so I'm not quite sure how to work around this.
> >
> > Maybe in the end it does have to be packaging-specific, with the
> > link created by the distro pkg scripts...?
>
> Ted, your change broke any builds span 2 different filesystems.
I thought I fixed this with commit 1e082c62?
Which Makefile is breaking? Is this the one in lib/et/Makefile.in?
It currently reads:
$(Q) (cd $(DESTDIR)$(includedir) ;\
$(LN) $(LINK_INSTALL_FLAGS) et/com_err.h . )
and I don't see how that could have generated the error you've cited
above...
- Ted
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] e2fsprogs: create com_err.h symlink in includedir
2011-06-17 2:31 ` Ted Ts'o
@ 2011-06-17 3:54 ` Andreas Dilger
2011-06-17 14:27 ` Eric Sandeen
1 sibling, 0 replies; 7+ messages in thread
From: Andreas Dilger @ 2011-06-17 3:54 UTC (permalink / raw)
To: Ted Ts'o; +Cc: Eric Sandeen, ext4 development, mitchb, Bruce Cassidy
On 2011-06-16, at 8:31 PM, Ted Ts'o wrote:
> On Thu, Jun 16, 2011 at 03:39:07PM -0500, Eric Sandeen wrote:
>>> Hm, now in a "make rpm" build which has source in one place and rpm build
>>> area in another:
>>>
>>> /bin/ln: creating hard link `/home/sandeen/rpmbuild/BUILDROOT/e2fsprogs-1.41.14-0.x86_64/usr/include/com_err.h' => `/usr/include/et/com_err.h': Invalid cross-device link
>>>
>>> so I'm not quite sure how to work around this.
>>>
>>> Maybe in the end it does have to be packaging-specific, with the
>>> link created by the distro pkg scripts...?
>>
>> Ted, your change broke any builds span 2 different filesystems.
>
> I thought I fixed this with commit 1e082c62?
>
> Which Makefile is breaking? Is this the one in lib/et/Makefile.in?
> It currently reads:
>
> $(Q) (cd $(DESTDIR)$(includedir) ;\
> $(LN) $(LINK_INSTALL_FLAGS) et/com_err.h . )
>
> and I don't see how that could have generated the error you've cited
> above...
I had to return the "-s" back as well, but the current code looks OK.
The chance of separate filesystems for /usr/include and /usr/include/et
being used seems vanishingly small.
Cheers, Andreas
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] e2fsprogs: create com_err.h symlink in includedir
2011-06-17 2:31 ` Ted Ts'o
2011-06-17 3:54 ` Andreas Dilger
@ 2011-06-17 14:27 ` Eric Sandeen
1 sibling, 0 replies; 7+ messages in thread
From: Eric Sandeen @ 2011-06-17 14:27 UTC (permalink / raw)
To: Ted Ts'o; +Cc: ext4 development, mitchb, Bruce Cassidy
On 6/16/11 9:31 PM, Ted Ts'o wrote:
> On Thu, Jun 16, 2011 at 03:39:07PM -0500, Eric Sandeen wrote:
>>> Hm, now in a "make rpm" build which has source in one place and rpm build
>>> area in another:
>>>
>>> /bin/ln: creating hard link `/home/sandeen/rpmbuild/BUILDROOT/e2fsprogs-1.41.14-0.x86_64/usr/include/com_err.h' => `/usr/include/et/com_err.h': Invalid cross-device link
>>>
>>> so I'm not quite sure how to work around this.
>>>
>>> Maybe in the end it does have to be packaging-specific, with the
>>> link created by the distro pkg scripts...?
>>
>> Ted, your change broke any builds span 2 different filesystems.
>
> I thought I fixed this with commit 1e082c62?
Oh, maybe you did; I didn't see any reply to my original problem report,
and I didn't see the patch sent to the list (maybe I missed it?)
So I assumed it wasn't yet fixed, TBH I don't usually build cross-fs
that way so hadn't actually retested, sorry. Seems like it should
be fine now, thanks.
As for Andreas' comment:
> I had to return the "-s" back as well, but the current code looks OK.
> The chance of separate filesystems for /usr/include and /usr/include/et
> being used seems vanishingly small.
my problem was actually during the RPM packaging, so a slightly different
situation.
-Eric
> Which Makefile is breaking? Is this the one in lib/et/Makefile.in?
> It currently reads:
>
> $(Q) (cd $(DESTDIR)$(includedir) ;\
> $(LN) $(LINK_INSTALL_FLAGS) et/com_err.h . )
>
> and I don't see how that could have generated the error you've cited
> above...
>
> - Ted
>
>
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2011-06-17 14:27 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-02-16 18:01 [PATCH] e2fsprogs: create com_err.h symlink in includedir Eric Sandeen
2011-02-20 23:10 ` Ted Ts'o
2011-03-19 15:03 ` Eric Sandeen
2011-06-16 20:39 ` Eric Sandeen
2011-06-17 2:31 ` Ted Ts'o
2011-06-17 3:54 ` Andreas Dilger
2011-06-17 14:27 ` Eric Sandeen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).