From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tao Ma Subject: Re: [PATCH] ext4: Remove redundant check for first_not_zeroed in ext4_register_li_request. Date: Mon, 28 Mar 2011 21:58:05 +0800 Message-ID: <4D9093ED.4070708@tao.ma> References: <1301298622-4014-1-git-send-email-tm@tao.ma> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: linux-ext4@vger.kernel.org To: Lukas Czerner Return-path: Received: from cpoproxy1-pub.bluehost.com ([69.89.21.11]:51392 "HELO outbound-mail-01.bluehost.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1754533Ab1C1N6W (ORCPT ); Mon, 28 Mar 2011 09:58:22 -0400 In-Reply-To: Sender: linux-ext4-owner@vger.kernel.org List-ID: On 03/28/2011 08:41 PM, Lukas Czerner wrote: > On Mon, 28 Mar 2011, Lukas Czerner wrote: > >> On Mon, 28 Mar 2011, Tao Ma wrote: >> >>> From: Tao Ma >>> >>> We have checked first_not_zeroed == ngroups already above, >>> so remove this redundant check. >>> >>> Signed-off-by: Tao Ma >>> --- >>> fs/ext4/super.c | 5 ----- >>> 1 files changed, 0 insertions(+), 5 deletions(-) >>> >>> diff --git a/fs/ext4/super.c b/fs/ext4/super.c >>> index 2d1378f..37448a7 100644 >>> --- a/fs/ext4/super.c >>> +++ b/fs/ext4/super.c >>> @@ -2953,11 +2953,6 @@ static int ext4_register_li_request(struct super_block *sb, >>> return 0; >>> } >>> >>> - if (first_not_zeroed == ngroups) { >>> - sbi->s_li_request = NULL; >>> - return 0; >>> - } >>> - >>> elr = ext4_li_request_new(sb, first_not_zeroed); >>> if (!elr) >>> return -ENOMEM; >>> >> >> Patch looks good. >> >> Thanks! >> -Lukas > > Just one tiny thing, we do not even need to set > sbi->s_li_request = NULL since it is NULL already and we check that > in the beginning of the function. yeah, another patch will be sent for this. thanks for the review. ;) Regards, Tao